Radish alpha
r
radicle-ci-broker
rad:zwTxygwuz5LDGBq255RA2CbNGrz8
Radicle CI broker
Radicle
Git
Patches › bc2cc001
Chore: Prohibit cib from logging sensitive configuration
Merged did:key:z6MkkpTP...arsB opened 1 year ago

Changed debug2 with a newly added func adapter_config in cib wchich logs adapter’s configuration without the sensitive environment variables.

Signed-off-by: Michalis Zampetakis mzampetakis@gmail.com

Activity Changes +5 -2
2 files changed +5 -2 975ce518 → 48f40d53
modified src/bin/cib.rs
@@ -141,7 +141,7 @@ impl QueuedCmd {
        let adapter = Adapter::new(&spec.command)

            .with_environment(spec.envs())

            .with_environment(spec.sensitive_envs());
- 
        logger::debug2(format!("default adapter: {adapter:?}"));
+ 
        logger::adapter_config(&config);

        broker.set_default_adapter(&adapter);



        let mut event_notifications = NotificationChannel::default();
@@ -215,7 +215,7 @@ impl ProcessEventsCmd {
        let adapter = Adapter::new(&spec.command)

            .with_environment(spec.envs())

            .with_environment(spec.sensitive_envs());
- 
        logger::debug2(format!("default adapter: {adapter:?}"));
+ 
        logger::adapter_config(&config);

        broker.set_default_adapter(&adapter);



        let processor = QueueProcessorBuilder::default()
modified src/logger.rs
@@ -67,6 +67,9 @@ pub fn end_cib_in_error() {
pub fn loaded_config(config: &Config) {

    debug!(slog_scope::logger(), "loaded configuration {config:#?}");

}
+ 
pub fn adapter_config(config: &Config) {
+ 
    debug!(slog_scope::logger(), "adapter configuration {config:#?}");
+ 
}



pub fn queueproc_start() {

    info!(