Changed debug2 with a newly added func adapter_config in cib wchich logs adapter’s configuration without the sensitive environment variables.
Signed-off-by: Michalis Zampetakis mzampetakis@gmail.com
Changed debug2 with a newly added func adapter_config in cib wchich logs adapter’s configuration without the sensitive environment variables.
Signed-off-by: Michalis Zampetakis mzampetakis@gmail.com
This has clippy warnings:
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/bin/cib.rs:144:32
|
144 | logger::adapter_config(&config);
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/bin/cib.rs:218:32
|
218 | logger::adapter_config(&config);
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
I’ll fix those.
I’m not sure this actually prevents sensitive environment variables from being logged. It would seem to require that the minimum logging level is higher than DEBUG. At the moment the CI broker doesn’t have a way of setting that, but that will happen fairly soon, so I’m not worried about that right now.
Fixes to prepare patch to be merged.