Radish alpha
r
rad:z4V1sjrXqjvFdnCUbxPFqd5p4DtH5
Radicle web interface
Radicle
Git
http: Make clippy throw errors
Open did:key:z6MkkfM3...sVz5 opened 1 year ago

Instead of failing silently, clippy warnings should be treated as errors and be fixed before merging a patch

check check-visual check-unit-test check-http-client-unit-test check-radicle-httpd check-e2e check-build check-http

👉 Preview 👉 Workflow runs 👉 Branch on GitHub

1 file changed +9 -3 9dd61d3b 2bbcc2f9
modified .github/workflows/check-radicle-httpd.yml
@@ -16,6 +16,8 @@ jobs:
          workspaces: radicle-httpd -> target
      - name: Build
        run: cargo build --all-features
+
        env:
+
          RUSTFLAGS: -D warnings
      - name: Run tests
        run: cargo test --all-features
  docs:
@@ -31,7 +33,9 @@ jobs:
        with:
          workspaces: radicle-httpd -> target
      - name: Docs
-
        run: cargo doc --all --all-features
+
        run: cargo doc --all-features
+
        env:
+
          RUSTDOCFLAGS: -D warnings
  lint:
    name: Lint
    runs-on: ubuntu-latest
@@ -45,6 +49,8 @@ jobs:
        with:
          workspaces: radicle-httpd -> target
      - name: Run clippy
-
        run: cargo clippy --all --tests
+
        run: cargo clippy --tests
+
        env:
+
          RUSTFLAGS: -D warnings
      - name: Check formatting
-
        run: cargo fmt --all --check
+
        run: cargo fmt -- --check