Radish alpha
r
rad:z4V1sjrXqjvFdnCUbxPFqd5p4DtH5
Radicle web interface
Radicle
Git
Underline markdown links that have emojis
Merged did:key:z6MkkfM3...sVz5 opened 2 years ago
3 files changed +10 -1 127efc49 187a67e0
modified src/components/Markdown.svelte
@@ -111,7 +111,11 @@
        console.warn("Not able to parse url", e);
      }
      // Don't underline <a> tags that contain images.
-
      if (e.firstElementChild instanceof HTMLImageElement) {
+
      // Make an exception for emojis.
+
      if (
+
        e.firstElementChild instanceof HTMLImageElement &&
+
        !e.firstElementChild.classList.contains("txt-emoji")
+
      ) {
        e.classList.add("no-underline");
      }
    }
modified tests/fixtures/repos/markdown.tar.bz2
modified tests/visual/desktop/markdown.spec.ts
@@ -160,6 +160,11 @@ test("relative image not able to being loaded", async ({ page }) => {
  await expect(page).toHaveScreenshot({ fullPage: true });
});

+
test("underline links that contain emojis", async ({ page }) => {
+
  await page.goto(`${markdownUrl}/tree/main/link-files.md`);
+
  await expect(page).toHaveScreenshot({ fullPage: true });
+
});
+

test("markdown in issues is not overflowing", async ({ page }) => {
  await page.goto(`${markdownUrl}/issues`, {
    waitUntil: "networkidle",