Radish alpha
r
rad:z4V1sjrXqjvFdnCUbxPFqd5p4DtH5
Radicle web interface
Radicle
Git
build: switch to build args over env vars in dockerfile
Open yorgos-laptop opened 1 year ago

--env is a podman-specific feature. While it is clear that podman is a requirement here, switching these to build arguments better expresses intent.

These values are meant to be configurable at build time, which is exactly what build arguments are for, while environment variables are meant to persist in the image built.

Additionally, this removes unused env vars.

Signed-off-by: Yorgos Saslis yorgos.work@proton.me

yorgos-laptop opened with revision a3e76773 on base 06e33f4a +18 -13 1 year ago

--env is a podman-specific feature. While it is clear that podman is a requirement here, switching these to build arguments better expresses intent.

These values are meant to be configurable at build time, which is exactly what build arguments are for, while environment variables are meant to persist in the image built.

Additionally, this removes unused env vars.

Signed-off-by: Yorgos Saslis yorgos.work@proton.me

did:key:z6MkkfM3...sVz5 pushed revision 2 c6fc426f on base 730f7ae1 +0 -0 1 year ago

Rebase

rudolfs accepted 1 year ago