π Preview π Workflow runs π Branch on GitHub
π Preview π Workflow runs π Branch on GitHub
Hey mog first thanks for your patch!
So having the node description being raw html has some security concerns around injection of malicious codes into nodes that can be executed on user machines, which we address by escaping it by svelte. If we want to apply your patch I think we should at least sanitize it with dompurify how we do it in some other places around the repo.
See this example in Markdown.svelte
changes requested by sebastinez
Thanks for feedback. I think this is what you are looking for. If you look at https://rad.rldn.net, this is what I am trying to use it for, using the more secure version you suggested seems to work
fixes requested by sebastinez
better escaping of html
Simplify node description parsing
We probably donβt need the markdown extension for the description.
@mog would be ok with that change? I think we donβt need the full featured markdown parsing we do for markdown files for the node description, wdyt?
Yes this modified patch solves my issue
Rename commits
Rebase
Add node description to tests to check for correct markdown parsing
Move Renderer back