Radish alpha
r
radicle-explorer
rad:z4V1sjrXqjvFdnCUbxPFqd5p4DtH5
Radicle web interface
Radicle
Git
Patches › 41eb5818
Fix commit colors and add new links to commit pages
Merged did:key:z6MkkfM3...sVz5 opened 1 year ago

check check-visual check-unit-test check-httpd-api-unit-test check-e2e check-build

👉 Preview 👉 Workflow runs 👉 Branch on GitHub

Activity Changes +40 -16
5 files changed +40 -16 8c069387 → b4234e44
modified src/components/CompactCommitAuthorship.svelte
@@ -94,9 +94,7 @@
      {/if}

    </div>

  </HoverPopover>
- 
  <div class="global-commit">
- 
    {utils.formatCommit(commit.id)}
- 
  </div>
+ 
  <slot />

  <div title={utils.absoluteTimestamp(commit.committer.time)}>

    {utils.formatTimestamp(commit.committer.time)}

  </div>
modified src/views/projects/Cob/CobCommitTeaser.svelte
@@ -3,6 +3,7 @@


  import { twemoji } from "@app/lib/utils";
+ 
  import CommitLink from "@app/views/projects/components/CommitLink.svelte";

  import CompactCommitAuthorship from "@app/components/CompactCommitAuthorship.svelte";

  import ExpandButton from "@app/components/ExpandButton.svelte";

  import IconButton from "@app/components/IconButton.svelte";
@@ -86,13 +87,17 @@
      </div>

    {/if}

    <div class="global-hide-on-small-desktop-up">
- 
      <CompactCommitAuthorship {commit} />
+ 
      <CompactCommitAuthorship {commit}>
+ 
        <CommitLink {baseUrl} {projectId} commitId={commit.id} />
+ 
      </CompactCommitAuthorship>

    </div>

  </div>

  <div class="right">

    <div style="display: flex; gap: 0.5rem; height: 21px; align-items: center;">

      <div class="global-hide-on-mobile-down">
- 
        <CompactCommitAuthorship {commit} />
+ 
        <CompactCommitAuthorship {commit}>
+ 
          <CommitLink {baseUrl} {projectId} commitId={commit.id} />
+ 
        </CompactCommitAuthorship>

      </div>

      <IconButton title="Browse repo at this commit">

        <Link
modified src/views/projects/Cob/Revision.svelte
@@ -18,6 +18,7 @@


  import CobCommitTeaser from "@app/views/projects/Cob/CobCommitTeaser.svelte";

  import CommentComponent from "@app/components/Comment.svelte";
+ 
  import CommitLink from "@app/views/projects/components/CommitLink.svelte";

  import DiffStatBadge from "@app/components/DiffStatBadge.svelte";

  import DropdownList from "@app/components/DropdownList.svelte";

  import DropdownListItem from "@app/components/DropdownList/DropdownListItem.svelte";
@@ -412,9 +413,7 @@
              alias={revisionAuthor.alias} />

            {#if patchId === revisionId}

              opened this patch on base
- 
              <span class="global-oid">
- 
                {utils.formatObjectId(revisionBase)}
- 
              </span>
+ 
              <CommitLink {baseUrl} {projectId} commitId={revisionBase} />

            {:else}

              updated to

              <span class="global-oid">
@@ -422,9 +421,7 @@
              </span>

              {#if previousRevBase && previousRevBase !== revisionBase}

                with base
- 
                <span class="global-oid">
- 
                  {utils.formatObjectId(revisionBase)}
- 
                </span>
+ 
                <CommitLink {baseUrl} {projectId} commitId={revisionBase} />

              {/if}

            {/if}

            <span
@@ -567,9 +564,10 @@
                {utils.formatObjectId(element.inner.revision)}

              </span>

              at commit
- 
              <span class="global-commit">
- 
                {utils.formatCommit(element.inner.commit)}
- 
              </span>
+ 
              <CommitLink
+ 
                {baseUrl}
+ 
                {projectId}
+ 
                commitId={element.inner.commit} />

              <span

                class="timestamp"

                title={utils.absoluteTimestamp(revisionTimestamp)}>
modified src/views/projects/Commit/CommitTeaser.svelte
@@ -1,9 +1,10 @@
<script lang="ts">

  import type { BaseUrl, CommitHeader } from "@httpd-client";
- 
  import { formatCommit, twemoji } from "@app/lib/utils";
+ 
  import { twemoji } from "@app/lib/utils";



  import CommitAuthorship from "./CommitAuthorship.svelte";
+ 
  import CommitLink from "@app/views/projects/components/CommitLink.svelte";

  import ExpandButton from "@app/components/ExpandButton.svelte";

  import IconButton from "@app/components/IconButton.svelte";

  import IconSmall from "@app/components/IconSmall.svelte";
@@ -100,7 +101,7 @@
      </div>

    {/if}

    <CommitAuthorship header={commit}>
- 
      <span class="global-commit">{formatCommit(commit.id)}</span>
+ 
      <CommitLink {baseUrl} {projectId} commitId={commit.id} />

    </CommitAuthorship>

  </div>

  <div class="right">
added src/views/projects/components/CommitLink.svelte
@@ -0,0 +1,22 @@
+ 
<script lang="ts">
+ 
  import type { BaseUrl } from "@httpd-client";
+
+ 
  import { formatCommit } from "@app/lib/utils";
+ 
  import Link from "@app/components/Link.svelte";
+
+ 
  export let baseUrl: BaseUrl;
+ 
  export let projectId: string;
+ 
  export let commitId: string;
+ 
</script>
+
+ 
<Link
+ 
  route={{
+ 
    resource: "project.commit",
+ 
    node: baseUrl,
+ 
    project: projectId,
+ 
    commit: commitId,
+ 
  }}>
+ 
  <span class="global-commit">
+ 
    {formatCommit(commitId)}
+ 
  </span>
+ 
</Link>