Limit embed file size to 10MB — radicle-desktop

modified crates/radicle-types/src/error.rs

@@ -19,6 +19,10 @@ pub enum Error {

     #[error("ssh agent not running")]
     AgentNotRunning,
     /// File size too big
     #[error("file size too large: {0}")]
     FileTooLarge(usize),
     /// Generic Cob cache error.
     #[error(transparent)]
     Cache(#[from] radicle::cob::cache::Error),

modified crates/radicle-types/src/traits/thread.rs

@@ -64,6 +64,10 @@ pub trait Thread: Profile {

         let profile = self.profile();
         let repo = profile.storage.repository(rid)?;
         let bytes = fs::read(path.clone())?;
         let file_size = bytes.len();
         if file_size > 10_485_760 {
             return Err(Error::FileTooLarge(file_size));
         }
         let name = path.file_name().and_then(|s| s.to_str()).unwrap_or("embed");
         let embed = radicle::cob::Embed::<git::Oid>::store(name, &bytes, &repo.backend)?;

@@ -76,6 +80,10 @@ pub trait Thread: Profile {

         name: String,
         bytes: Vec<u8>,
     ) -> Result<git::Oid, Error> {
         let file_size = bytes.len();
         if file_size > 10_485_760 {
             return Err(Error::FileTooLarge(file_size));
         }
         let profile = self.profile();
         let repo = profile.storage.repository(rid)?;
         let embed = radicle::cob::Embed::<git::Oid>::store(&name, &bytes, &repo.backend)?;

modified src/components/ExtendedTextarea.svelte

@@ -1,10 +1,12 @@

 <script lang="ts">
   import type { UnlistenFn } from "@tauri-apps/api/event";
   import type { ComponentProps } from "svelte";
   import type { Embed } from "@bindings/cob/thread/Embed";
   import debounce from "lodash/debounce";
   import * as utils from "@app/lib/utils";
   import type { Embed } from "@bindings/cob/thread/Embed";
   import { invoke } from "@app/lib/invoke";
   import { listen } from "@tauri-apps/api/event";
   import { onDestroy, onMount } from "svelte";

@@ -70,10 +72,15 @@

   let selectionStart = $state(body.length);
   let selectionEnd = $state(body.length);
   let draggingOver = $state(false);
   let embedUploadError: string | undefined = $state();
   let dragEnterUnlistenFn: UnlistenFn | undefined = undefined;
   let dragLeaveUnlistenFn: UnlistenFn | undefined = undefined;
   let dragDropUnlistenFn: UnlistenFn | undefined = undefined;
   const restoreDragDropText = debounce(() => {
     embedUploadError = undefined;
   }, 5000);
   function updateBodyAndSelection(input: string[], pre: string, after: string) {
     const allEmbeds = input.join("");
     body = pre.concat(allEmbeds, after);

@@ -110,12 +117,18 @@

               const uploadLabel = `[Uploading ${name}...]()\n`;
               body = preBody.concat(uploadLabel, afterBody);
               const oid = await invoke<string>("save_embed_by_path", {
                 rid,
                 path,
               });
               embeds.set(oid, { name, content: `git:${oid}` });
               return `[${name}](${oid})\n`;
               try {
                 const oid = await invoke<string>("save_embed_by_path", {
                   rid,
                   path,
                 });
                 embeds.set(oid, { name, content: `git:${oid}` });
                 return `[${name}](${oid})\n`;
               } catch {
                 embedUploadError = "Upload failed, embed exceeded 10Mb.";
                 restoreDragDropText();
                 return "";
               }
             }),
           ).then(texts => updateBodyAndSelection(texts, preBody, afterBody));
         });

@@ -138,12 +151,18 @@

         const name = pathSegments[pathSegments.length - 1];
         const uploadLabel = `[Uploading ${name}...]()\n`;
         body = preBody.concat(uploadLabel, afterBody);
         const oid = await invoke<string>("save_embed_by_path", {
           rid,
           path,
         });
         embeds.set(oid, { name: name ?? path, content: `git:${oid}` });
         return `[${name}](${oid})\n`;
         try {
           const oid = await invoke<string>("save_embed_by_path", {
             rid,
             path,
           });
           embeds.set(oid, { name: name ?? path, content: `git:${oid}` });
           return `[${name}](${oid})\n`;
         } catch {
           embedUploadError = "Upload failed, embed exceeded 10Mb.";
           restoreDragDropText();
           return "";
         }
       }),
     ).then(texts => updateBodyAndSelection(texts, preBody, afterBody));
   }

@@ -161,12 +180,19 @@

         const file = e.clipboardData.files[0];
         const uploadLabel = `[Uploading...]()\n`;
         body = preBody.concat(uploadLabel, afterBody);
         const oid = await invoke<string>("save_embed_by_clipboard", {
           name: file.name,
           rid,
         });
         embeds.set(oid, { name: file.name, content: `git:${oid}` });
         body = preBody.concat(`[${file.name}](${oid})\n`, afterBody);
         try {
           const oid = await invoke<string>("save_embed_by_clipboard", {
             name: file.name,
             rid,
           });
           embeds.set(oid, { name: file.name, content: `git:${oid}` });
           body = preBody.concat(`[${file.name}](${oid})\n`, afterBody);
         } catch {
           body = preBody.concat(``, afterBody);
           embedUploadError = "Upload failed, embed exceeded 10Mb.";
           restoreDragDropText();
         }
       } else {
         return Promise.all(
           Array.from(e.clipboardData.files).map(async file => {

@@ -174,13 +200,19 @@

             const bytes = new Uint8Array(arrayBuffer);
             const uploadLabel = `[Uploading ${file.name}...]()\n`;
             body = preBody.concat(uploadLabel, afterBody);
             const oid = await invoke<string>("save_embed_by_bytes", {
               rid,
               name: file.name,
               bytes,
             });
             embeds.set(oid, { name: file.name, content: `git:${oid}` });
             return `[${file.name}](${oid})\n`;
             try {
               const oid = await invoke<string>("save_embed_by_bytes", {
                 rid,
                 name: file.name,
                 bytes,
               });
               embeds.set(oid, { name: file.name, content: `git:${oid}` });
               return `[${file.name}](${oid})\n`;
             } catch {
               embedUploadError = "Upload failed, embed exceeded 10Mb.";
               restoreDragDropText();
               return "";
             }
           }),
         ).then(texts => updateBodyAndSelection(texts, preBody, afterBody));
       }

@@ -283,9 +315,22 @@

     </OutlineButton>
     {#if !preview}
       <div
         style:display=""
         class="txt-overflow txt-small txt-missing"
         title={`${allowAttachments ? "Drag and drop files to add them. " : ""}Markdown is supported. Press ${utils.modifierKey()}↵ to submit.`}>
         {#if allowAttachments}Drag and drop files to add them.{/if}
         {#if allowAttachments}
           {#if embedUploadError}
             <span style:color="var(--color-fill-danger)">
               <Icon
                 styleDisplay="inline"
                 styleVerticalAlign="text-top"
                 name="warning" />
               {embedUploadError}
             </span>
           {:else}
             Drag and drop files to add them.
           {/if}
         {/if}
         <Icon
           name="markdown"
           styleDisplay="inline"

modified src/components/Textarea.svelte

@@ -200,6 +200,8 @@

     onkeydown={handleKeydown}>
   </textarea>
   {#if draggingOver}
     <div class="txt-small dragover">Drop files to add them as embeds.</div>
     <div class="txt-small dragover">
       Drop files to add them as embeds. Embeds are limited to 10Mb.
     </div>
   {/if}
 </Border>