Radish alpha
r
radicle-desktop
rad:z4D5UCArafTzTQpDZNQRuqswh3ury
Radicle desktop app
Radicle
Git
Patches › c7b54f5b
Polish patch review visuals
Open rudolfs opened 1 year ago

check check-e2e

👉 Workflow runs 👉 Branch on GitHub

Activity Changes +37 -9
3 files changed +37 -9 efe3c51d → aced47f0
modified src/components/Diff.svelte
@@ -249,10 +249,13 @@
    position: relative;

    cursor: cell;

  }
- 
  .left:hover,
- 
  .right:hover,
- 
  .left:active,
- 
  .right:active {
+ 
  .selection-disabled {
+ 
    cursor: default;
+ 
  }
+ 
  .left:hover:not(.selection-disabled),
+ 
  .right:hover:not(.selection-disabled),
+ 
  .left:active:not(.selection-disabled),
+ 
  .right:active:not(.selection-disabled) {

    color: var(--color-foreground-contrast);

  }

  .sign {
@@ -332,6 +335,7 @@
              isSelected(filePath(file, "left"), hunkIdx, lineIdx)}>

            <div

              class="left"
+ 
              class:selection-disabled={!codeComments || thread}

              class:marker={selection?.start.side === "left" &&

                selection.start.lineNumber === lineNumber(line, "left")}

              onpointerdown={e => {
@@ -344,6 +348,7 @@


            <div

              class="right"
+ 
              class:selection-disabled={!codeComments || thread}

              class:marker={selection?.start.side === "right" &&

                selection.start.lineNumber === lineNumber(line, "right")}

              onpointerdown={e => {
modified src/components/ReviewTeaser.svelte
@@ -21,9 +21,17 @@
    review: Review;

    rid: string;

    status: PatchStatus | undefined;
+ 
    first?: boolean;
+ 
    last?: boolean;

  }
- 
  const { patchId, review, rid, status }: Props = $props();
+ 
  const { patchId, review, rid, status, first, last }: Props = $props();
+ 
  const style = $derived(
+ 
    (first && last && "--local-clip-path: var(--2px-corner-fill)") ||
+ 
      (first && "--local-clip-path: var(--2px-top-corner-fill)") ||
+ 
      (last && "--local-clip-path: var(--2px-bottom-corner-fill)") ||
+ 
      "",
+ 
  );

</script>



<style>
@@ -41,7 +49,7 @@
    z-index: -1;

    content: " ";

    background-color: var(--color-fill-float);
- 
    clip-path: var(--2px-corner-fill);
+ 
    clip-path: var(--local-clip-path);

    width: 100%;

    height: 100%;

    top: 0;
@@ -92,6 +100,7 @@
  tabindex="0"

  role="button"

  class="review"
+ 
  {style}

  style:cursor="pointer"

  onclick={() => {

    void push({
modified src/components/Reviews.svelte
@@ -74,6 +74,12 @@
  .hide {

    display: none;

  }
+ 
  .review-list {
+ 
    margin-top: 1rem;
+ 
    display: flex;
+ 
    flex-direction: column;
+ 
    gap: 2px;
+ 
  }

</style>



<div style:margin={hideReviews ? "1.5rem 0" : "1.5rem 0 2.5rem 0"}>
@@ -119,9 +125,17 @@
  </div>



  {#if revision.reviews && revision.reviews.length}
- 
    <div class:hide={hideReviews} style:margin-top="1rem">
- 
      {#each revision.reviews as review}
- 
        <ReviewTeaser {rid} {review} {patchId} {status} />
+ 
    <div class:hide={hideReviews} class="review-list">
+ 
      {#each revision.reviews as review, idx}
+ 
        <ReviewTeaser
+ 
          {rid}
+ 
          {review}
+ 
          {patchId}
+ 
          {status}
+ 
          first={idx === 0}
+ 
          last={idx === revision.reviews.length - 1} />
+ 
        {console.log("length", revision.reviews.length)}
+ 
        {console.log("idx", idx)}

      {/each}

    </div>

  {/if}