Radish alpha
r
rad:z4D5UCArafTzTQpDZNQRuqswh3ury
Radicle desktop app
Radicle
Git
Move inbox to a global popover
Open rudolfs opened 1 year ago

Move the inbox into a popover that’s accessible globally.

  • refresh inbox counter and app icon badge every 3 seconds
  • show a button to load new notifications in case new ones come in when the popover is open
  • repo pinning and hiding
  • simplify backend into one call
  • load 100 notifications per repo and show a More button if there are more
  • Inbox 0 message when there are no notifications

check check-e2e check-unit-test

👉 Workflow runs 👉 Branch on GitHub

rudolfs opened with revision c3cec8ee on base 724132ab +199 -391 1 year ago

Move the inbox into a popover that’s accessible globally.

  • refresh inbox counter and app icon badge every 3 seconds
  • show a button to load new notifications in case new ones come in when the popover is open
  • repo pinning and hiding
  • simplify backend into one call
  • load 100 notifications per repo and show a More button if there are more
  • Inbox 0 message when there are no notifications

check check-e2e check-unit-test

👉 Workflow runs 👉 Branch on GitHub

rudolfs pushed revision 2 91bff5a0 on base 724132ab +201 -391 1 year ago

Hide counter if undefined

rudolfs pushed revision 3 d3f8247c on base 2c2a5abc +201 -391 1 year ago

Rebase

rudolfs pushed revision 4 08101c5e on base 2c2a5abc +207 -391 1 year ago

Make the popover fixed height

rudolfs pushed revision 5 c4fd6f53 on base 2c2a5abc +230 -421 1 year ago

Fix clear all modals

rudolfs pushed revision 6 048cc8ca on base ea2982fa +230 -421 1 year ago

Rebase

rudolfs pushed revision 7 fd313272 on base ea2982fa +254 -421 1 year ago

Replace total count function

rudolfs pushed revision 8 d982531f on base c754c4f3 +254 -421 1 year ago

Rebase

rudolfs pushed revision 9 4d2f154c on base c754c4f3 +220 -439 1 year ago

Cleanup

rudolfs pushed revision 10 f8f67f87 on base c754c4f3 +229 -443 1 year ago

Make confirm clear nicer

rudolfs pushed revision 11 080e5e86 on base c754c4f3 +239 -460 1 year ago

Small things

rudolfs pushed revision 12 ca59ae17 on base c754c4f3 +245 -458 1 year ago

Update total notification counter on clear

rudolfs pushed revision 13 713ea314 on base c754c4f3 +308 -553 1 year ago

Refactor

rudolfs pushed revision 14 5954ef78 on base 03d7f8ae +308 -553 1 year ago

Rebase

rudolfs pushed revision 15 eacf7d44 on base 03d7f8ae +339 -562 1 year ago

Refactor 1

Refactor 2

Fixup

Fixup

rudolfs pushed revision 16 07d2fc24 on base 03d7f8ae +354 -571 1 year ago

Poll inbox counter and set app badge

rudolfs pushed revision 17 8e948f79 on base 03d7f8ae +356 -571 1 year ago

Remove badge if we have 0 notifications

rudolfs pushed revision 18 14e6d993 on base 03d7f8ae +356 -571 1 year ago

Squash

rudolfs pushed revision 19 3e432ea3 on base 03d7f8ae +358 -571 1 year ago

Fix specs

did:key:z6MkkfM3...sVz5 reviewed · 7 comments 1 year ago

Patch looks good so far.

Do we want to collapse repos? I feel like having all repos listed in the global inbox and not being able to collapse them, makes the inbox a bit less usable for me.

Visual comments in the discussion thread, due to embeds

rudolfs pushed revision 20 6b3df3f9 on base 2a7a430c +358 -571 1 year ago

Rebase

rudolfs pushed revision 21 0c6b19a3 on base deb46efa +358 -571 1 year ago

Rebase

rudolfs pushed revision 22 34f50c72 on base deb46efa +359 -572 1 year ago

Narrow down sql queries

rudolfs pushed revision 23 e0a89150 on base deb46efa +719 -738 1 year ago

Refactor into one back-end call

rudolfs pushed revision 24 4eccff85 on base deb46efa +732 -738 1 year ago

Refactor

rudolfs pushed revision 25 7cbd61d8 on base deb46efa +826 -726 1 year ago

Implement repo pinning in inbox

rudolfs pushed revision 26 f96d788c on base deb46efa +910 -724 1 year ago

Implement hiding too

rudolfs pushed revision 27 01252b14 on base deb46efa +917 -719 1 year ago

Better sorting and visual alignments

rudolfs pushed revision 28 2a0f9f0f on base deb46efa +921 -719 1 year ago

Visual tweaks

rudolfs pushed revision 29 daf96b8f on base deb46efa +939 -719 1 year ago

Implement Show All notifications

rudolfs pushed revision 30 b1f90e89 on base deb46efa +946 -719 1 year ago

Preserver pinning order and refresh notification list automatically

rudolfs pushed revision 31 cedc9446 on base deb46efa +951 -720 1 year ago
did:key:z6MkkfM3...sVz5 commented on revision 31 0 years ago

Is this revision of the patch final and reviewable or is there something missing?

rudolfs commented on revision 31 0 years ago

Moving it back to draft, haven’t had time to do a revision on it yet.

rudolfs pushed revision 32 6d4d10ef on base bb38192b +948 -721 11 months ago

Rebase

rudolfs pushed revision 33 66561b48 on base bb38192b +948 -721 11 months ago

Squash

rudolfs pushed revision 34 0ce53cee on base bb38192b +951 -725 11 months ago

Fix router loading things twice

rudolfs pushed revision 35 8ce52571 on base bb38192b +1083 -810 11 months ago

Move home router to its own module Load initial notification counter via router

rudolfs pushed revision 36 ca33c429 on base 5cb9aaa7 +1083 -810 11 months ago

Rebase

rudolfs pushed revision 37 9693400d on base aae2d6bf +1097 -812 11 months ago

Rebase.

rudolfs pushed revision 38 8929e56b on base aae2d6bf +1097 -812 11 months ago

Squash

rudolfs pushed revision 39 6a76a701 on base aae2d6bf +1102 -817 11 months ago

Make inbox variable height

rudolfs pushed revision 40 625e9258 on base aae2d6bf +1116 -817 11 months ago

Show a load more button when new notifications arrive

rudolfs pushed revision 41 5c64ea0d on base aae2d6bf +1116 -817 11 months ago

Fix counters

rudolfs commented on revision 31 11 months ago

I think now it is.

rudolfs pushed revision 42 b0f94a52 on base 25c6ab32 +1116 -817 11 months ago

Rebase

rudolfs pushed revision 43 6821586a on base 25c6ab32 +1098 -846 11 months ago

Rename and remove endpoints

rudolfs pushed revision 44 f2b3f42a on base 25c6ab32 +1098 -846 11 months ago

Another rename

I’m going to do one final refactor of the notification backend before review.

rudolfs pushed revision 45 cbda3543 on base ace80211 +1098 -846 11 months ago

Rebase

rudolfs commented on revision 45 11 months ago

TBD:

  • still some issue with total count vs per repo counts, seeing 7 total vs 6 inside, causes “See 1 new” button to appear and not go away, could be that a notification is counted towards total that isn’t part of a repo?
  • backend call refactor
rudolfs pushed revision 46 395bb298 on base 5dacfd0e +1089 -849 11 months ago

Rebase

rudolfs pushed revision 47 49a195de on base 5dacfd0e +1095 -851 11 months ago

Fix outline button color

rudolfs pushed revision 48 a14d72e8 on base 5dacfd0e +1095 -851 11 months ago

Always show clear all buttons

rudolfs pushed revision 49 461bdbf4 on base 5dacfd0e +1084 -851 11 months ago

Remove redundant comments

rudolfs pushed revision 50 4b431721 on base 5dacfd0e +1086 -853 11 months ago

Try to fix rust-toolchain shenanigans

rudolfs pushed revision 51 52a463c1 on base 5dacfd0e +1088 -853 11 months ago

Add clippy

rudolfs pushed revision 52 413df154 on base 5dacfd0e +1089 -854 11 months ago

Fix check-rs

rudolfs pushed revision 53 aff6ce54 on base 5dacfd0e +1086 -851 11 months ago

Revert

rudolfs pushed revision 54 e5151066 on base 5dacfd0e +1084 -851 11 months ago

Remove clippy

did:key:z6MkkfM3...sVz5 rejected · 2 comments 11 months ago

Found a small design issue when in light theme the text of the inbox popover toggle is white and not readable. I recommend something like this

diff --git a/src/components/OutlineButton.svelte b/src/components/OutlineButton.svelte
index de9dfa4..6a8c191 100644
--- a/src/components/OutlineButton.svelte
+++ b/src/components/OutlineButton.svelte
@@ -29,7 +29,7 @@
       `--button-color-3: var(--color-fill-${variant}-shade);` +
       // The ghost colors are called --color-fill-counter and --color-fill-counter-emphasized.
       `--button-color-4: var(--color-fill${variant === "ghost" ? "" : `-${variant}`}-counter);` +
-      `--text-color: ${variant === "ghost" ? "var(--color-foreground-contrast)" : "var(--color-foreground-white)"};` +
+      `--text-color: ${variant === "ghost" ? "var(--color-foreground-contrast)" : "var(--color-foreground-default)"};` +
       `--text-color-active: ${variant === "ghost" ? "var(--color-foreground-emphasized)" : "var(--color-foreground-white)"};`,
   );
 </script>
@@ -231,6 +231,10 @@
     background-color: var(--button-color-1);
   }
 
+  .container:hover:not(.disabled) {
+    color: var(--text-color);
+  }
+
   .container.active:not(.disabled) {
     color: var(--text-color-active);
   }

rudolfs pushed revision 55 43ae7e8b on base 5dacfd0e +1084 -851 11 months ago

Apply rust suggestion

rudolfs pushed revision 56 12201215 on base 5dacfd0e +1086 -851 11 months ago

Fix button hover color in light mode