Radish alpha
r
Radicle desktop app
Radicle
Git (anonymous pull)
Log in to clone via SSH
Move inbox to a global popover
✓ 1/1 checks passed rudolfs wants to merge 1 commit into main · opened 1 year ago

Move the inbox into a popover that's accessible globally.

  • refresh inbox counter and app icon badge every 3 seconds
  • show a button to load new notifications in case new ones come in when the popover is open
  • repo pinning and hiding
  • simplify backend into one call
  • load 100 notifications per repo and show a More button if there are more
  • Inbox 0 message when there are no notifications

check check-e2e check-unit-test

👉 Workflow runs 👉 Branch on GitHub

All checks passed — 1 passed View logs ↗
rudolfs opened with revision c3cec8eeeee3040ac8a038424eec340efbc1177a on base 724132abcc772c6868e2c1aa343426153f934b06 +199 -391 1 year ago
rudolfs marked as draft 1 year ago
rudolfs pushed revision 2 91bff5a021ae5cd250d04ded9537fa0eb51ee2af on base 724132abcc772c6868e2c1aa343426153f934b06 +201 -391 1 year ago

Hide counter if undefined

rudolfs pushed revision 3 d3f8247ce8cb03e4415274c700c08a408e52d28a on base 2c2a5abcd5ee776fc2efc18e58cd83be94dca463 +201 -391 1 year ago

Rebase

rudolfs pushed revision 4 08101c5ec319baa7a45ef1e152eea9302da26587 on base 2c2a5abcd5ee776fc2efc18e58cd83be94dca463 +207 -391 1 year ago

Make the popover fixed height

rudolfs pushed revision 5 c4fd6f5315e0aa29a38827c69186a254e09d108a on base 2c2a5abcd5ee776fc2efc18e58cd83be94dca463 +230 -421 1 year ago

Fix clear all modals

rudolfs pushed revision 6 048cc8ca97e985a112ccd0299b8c54aa2fd161ca on base ea2982faa2824caa676d135aa4197bea8964427e +230 -421 1 year ago

Rebase

rudolfs pushed revision 7 fd3132721e50c8d464697c7db08df35c31d7d2d5 on base ea2982faa2824caa676d135aa4197bea8964427e +254 -421 1 year ago

Replace total count function

rudolfs pushed revision 8 d982531f4865464db081f626753ae5d5b5077323 on base c754c4f365e5e5fd7ba0acd82d90e644d45d55d3 +254 -421 1 year ago

Rebase

rudolfs pushed revision 9 4d2f154cef13d897cd927faddb391bfedd23953a on base c754c4f365e5e5fd7ba0acd82d90e644d45d55d3 +220 -439 1 year ago

Cleanup

rudolfs pushed revision 10 f8f67f8760f42cdaedf3e648b467e93403a6db80 on base c754c4f365e5e5fd7ba0acd82d90e644d45d55d3 +229 -443 1 year ago

Make confirm clear nicer

rudolfs pushed revision 11 080e5e868df50c870031b122ed12934f3967b928 on base c754c4f365e5e5fd7ba0acd82d90e644d45d55d3 +239 -460 1 year ago

Small things

rudolfs pushed revision 12 ca59ae17297078f717dee374937e2c1eb7685f2d on base c754c4f365e5e5fd7ba0acd82d90e644d45d55d3 +245 -458 1 year ago

Update total notification counter on clear

rudolfs pushed revision 13 713ea314ba4b94e608c18c9e11405fb5d791c410 on base c754c4f365e5e5fd7ba0acd82d90e644d45d55d3 +308 -553 1 year ago

Refactor

rudolfs pushed revision 14 5954ef78b02f6d0a5a1eff268604b7c90b618ea3 on base 03d7f8ae6e3cff49849edb359d79532634aea73b +308 -553 1 year ago

Rebase

rudolfs pushed revision 15 eacf7d447207e6f51bf97766e4200d90b94a7dcc on base 03d7f8ae6e3cff49849edb359d79532634aea73b +339 -562 1 year ago

Refactor 1

Refactor 2

Fixup

Fixup

rudolfs pushed revision 16 07d2fc24a785bf926bb40c5326f2cfdd9391fceb on base 03d7f8ae6e3cff49849edb359d79532634aea73b +354 -571 1 year ago

Poll inbox counter and set app badge

rudolfs pushed revision 17 8e948f792aa1282d821bcb65ff26344acd6b39b7 on base 03d7f8ae6e3cff49849edb359d79532634aea73b +356 -571 1 year ago

Remove badge if we have 0 notifications

rudolfs pushed revision 18 14e6d993d19922e1037f67655d184fc3e6e0af0b on base 03d7f8ae6e3cff49849edb359d79532634aea73b +356 -571 1 year ago

Squash

rudolfs marked as ready 1 year ago
rudolfs pushed revision 19 3e432ea34e81d79ff1276d0f4d9995921f4866c6 on base 03d7f8ae6e3cff49849edb359d79532634aea73b +358 -571 1 year ago

Fix specs

sebastinez reviewed · 7 comments 1 year ago

Patch looks good so far.

Do we want to collapse repos? I feel like having all repos listed in the global inbox and not being able to collapse them, makes the inbox a bit less usable for me.

Visual comments in the discussion thread, due to embeds

rudolfs pushed revision 20 6b3df3f9957aa7910c2487b02f27220aec1f898e on base 2a7a430c4f783d1ec852641744e8a938d24f358f +358 -571 1 year ago

Rebase

rudolfs pushed revision 21 0c6b19a3438f5ddc29e0b65b6c268de043ef96c0 on base deb46efaec93b010872f5bfb6368cb6816aede7f +358 -571 1 year ago

Rebase

rudolfs pushed revision 22 34f50c72402b3737520e5512d6266d3d3e3f823c on base deb46efaec93b010872f5bfb6368cb6816aede7f +359 -572 1 year ago

Narrow down sql queries

rudolfs pushed revision 23 e0a89150abb21f1d6e8ddac57a1b0b107d108ab7 on base deb46efaec93b010872f5bfb6368cb6816aede7f +719 -738 1 year ago

Refactor into one back-end call

rudolfs pushed revision 24 4eccff859c5fdc9de123ad6e1204faae6a1f9dd1 on base deb46efaec93b010872f5bfb6368cb6816aede7f +732 -738 1 year ago

Refactor

rudolfs pushed revision 25 7cbd61d8048317b8804033ce5d13a5accb84cff4 on base deb46efaec93b010872f5bfb6368cb6816aede7f +826 -726 1 year ago

Implement repo pinning in inbox

rudolfs pushed revision 26 f96d788c059c2d083dc40dcea5450bad54de17b9 on base deb46efaec93b010872f5bfb6368cb6816aede7f +910 -724 1 year ago

Implement hiding too

rudolfs pushed revision 27 01252b141edd0be3e679bb5f83d1c6f91f12b957 on base deb46efaec93b010872f5bfb6368cb6816aede7f +917 -719 1 year ago

Better sorting and visual alignments

rudolfs pushed revision 28 2a0f9f0f72e9bf8fa3d86a857386faa853f5aca0 on base deb46efaec93b010872f5bfb6368cb6816aede7f +921 -719 1 year ago

Visual tweaks

rudolfs pushed revision 29 daf96b8f889b87eda0dade439c20294ccf2c5591 on base deb46efaec93b010872f5bfb6368cb6816aede7f +939 -719 1 year ago

Implement Show All notifications

rudolfs pushed revision 30 b1f90e89607186448da011a1309c0510df1e07d0 on base deb46efaec93b010872f5bfb6368cb6816aede7f +946 -719 1 year ago

Preserver pinning order and refresh notification list automatically

rudolfs pushed revision 31 cedc944694a59a6062878ddb7731c6dfd64d993a on base deb46efaec93b010872f5bfb6368cb6816aede7f +951 -720 1 year ago
sebastinez commented on revision 31 1 year ago

Is this revision of the patch final and reviewable or is there something missing?

rudolfs commented on revision 31 1 year ago

Moving it back to draft, haven't had time to do a revision on it yet.

rudolfs marked as draft 1 year ago
rudolfs pushed revision 32 6d4d10ef5d78fd9623d80966cd3215a5624b9c58 on base bb38192b7ec44ce248c5dd41f1155b5af2e9b7d6 +948 -721 1 year ago

Rebase

rudolfs pushed revision 33 66561b48e80657ad5ac5089ccba69064ef7dd751 on base bb38192b7ec44ce248c5dd41f1155b5af2e9b7d6 +948 -721 1 year ago

Squash

rudolfs pushed revision 34 0ce53cee91332c802d589657458afb4835b1852f on base bb38192b7ec44ce248c5dd41f1155b5af2e9b7d6 +951 -725 1 year ago

Fix router loading things twice

rudolfs pushed revision 35 8ce52571ca41e31ef5b5f3fd27bc92ba322a3376 on base bb38192b7ec44ce248c5dd41f1155b5af2e9b7d6 +1083 -810 1 year ago

Move home router to its own module Load initial notification counter via router

rudolfs pushed revision 36 ca33c429713dbafe0bcd86ae2f8570b4ff9f6b01 on base 5cb9aaa7fba01da40b4255ea25017099ab344c22 +1083 -810 1 year ago

Rebase

rudolfs pushed revision 37 9693400df7e9f5476e7f7605c0ffdacbac439b97 on base aae2d6bff4a04970ea298c443a997a4f1ea1022a +1097 -812 1 year ago

Rebase.

rudolfs pushed revision 38 8929e56ba7a4dfcd8a275bfb96ea39db74410603 on base aae2d6bff4a04970ea298c443a997a4f1ea1022a +1097 -812 1 year ago

Squash

rudolfs pushed revision 39 6a76a70199677a30b286369037fd80f4e84eeee7 on base aae2d6bff4a04970ea298c443a997a4f1ea1022a +1102 -817 1 year ago

Make inbox variable height

rudolfs pushed revision 40 625e925878e60d2acf04eb1617d2bd8478f356a4 on base aae2d6bff4a04970ea298c443a997a4f1ea1022a +1116 -817 1 year ago

Show a load more button when new notifications arrive

rudolfs pushed revision 41 5c64ea0d4e79238e6da0b0b3ac8ef54b64fee5c5 on base aae2d6bff4a04970ea298c443a997a4f1ea1022a +1116 -817 1 year ago

Fix counters

rudolfs marked as ready 1 year ago
rudolfs commented on revision 31 1 year ago

I think now it is.

rudolfs pushed revision 42 b0f94a525180d93cef70c26e5b4ee7237dd78e4a on base 25c6ab322b697ace4bd30bce2c515e659a14bccb +1116 -817 1 year ago

Rebase

rudolfs pushed revision 43 6821586a6d9757490c01530fae17d8b530ce6c38 on base 25c6ab322b697ace4bd30bce2c515e659a14bccb +1098 -846 1 year ago

Rename and remove endpoints

rudolfs pushed revision 44 f2b3f42abfbf6b534b9e33eec5ea755d86f775b7 on base 25c6ab322b697ace4bd30bce2c515e659a14bccb +1098 -846 1 year ago

Another rename

I'm going to do one final refactor of the notification backend before review.

rudolfs marked as draft 1 year ago
rudolfs pushed revision 45 cbda3543245f2c13720fb851b2fe067137abcb8a on base ace802118ec74c348a762456d2ae433ca4cfde91 +1098 -846 1 year ago

Rebase

rudolfs commented on revision 45 1 year ago

TBD:

  • still some issue with total count vs per repo counts, seeing 7 total vs 6 inside, causes "See 1 new" button to appear and not go away, could be that a notification is counted towards total that isn't part of a repo?
  • backend call refactor
rudolfs pushed revision 46 395bb29845674863a604090ad22ab5d8b8d3d8ab on base 5dacfd0edded380228b112e4fbac6d1b2915e49c +1089 -849 1 year ago

Rebase

rudolfs pushed revision 47 49a195de5eec93a730bcd3fdf36a1149581d22dd on base 5dacfd0edded380228b112e4fbac6d1b2915e49c +1095 -851 1 year ago

Fix outline button color

rudolfs pushed revision 48 a14d72e8fd8ccd6e368077f4e58f0af832ca5933 on base 5dacfd0edded380228b112e4fbac6d1b2915e49c +1095 -851 1 year ago

Always show clear all buttons

rudolfs marked as ready 1 year ago
rudolfs pushed revision 49 461bdbf41e780e0d311c3a8eea0a55672762955a on base 5dacfd0edded380228b112e4fbac6d1b2915e49c +1084 -851 1 year ago

Remove redundant comments

rudolfs pushed revision 50 4b43172132189a7d3b6d8b9da57a6c58f72716f2 on base 5dacfd0edded380228b112e4fbac6d1b2915e49c +1086 -853 1 year ago

Try to fix rust-toolchain shenanigans

rudolfs pushed revision 51 52a463c1c7019da8fb35c76f4e0ed44b35fe81ef on base 5dacfd0edded380228b112e4fbac6d1b2915e49c +1088 -853 1 year ago

Add clippy

rudolfs pushed revision 52 413df15492493400af28284c66703a74c8a17e36 on base 5dacfd0edded380228b112e4fbac6d1b2915e49c +1089 -854 1 year ago

Fix check-rs

rudolfs pushed revision 53 aff6ce549735bc7e2d4f3424d9655cb9dd717c72 on base 5dacfd0edded380228b112e4fbac6d1b2915e49c +1086 -851 1 year ago

Revert

rudolfs pushed revision 54 e5151066198d233efdb0f9b518b7703f4d58225b on base 5dacfd0edded380228b112e4fbac6d1b2915e49c +1084 -851 1 year ago

Remove clippy

sebastinez rejected · 2 comments 1 year ago

Found a small design issue when in light theme the text of the inbox popover toggle is white and not readable. I recommend something like this

diff --git a/src/components/OutlineButton.svelte b/src/components/OutlineButton.svelte
index de9dfa4..6a8c191 100644
--- a/src/components/OutlineButton.svelte
+++ b/src/components/OutlineButton.svelte
@@ -29,7 +29,7 @@
       `--button-color-3: var(--color-fill-${variant}-shade);` +
       // The ghost colors are called --color-fill-counter and --color-fill-counter-emphasized.
       `--button-color-4: var(--color-fill${variant === "ghost" ? "" : `-${variant}`}-counter);` +
-      `--text-color: ${variant === "ghost" ? "var(--color-foreground-contrast)" : "var(--color-foreground-white)"};` +
+      `--text-color: ${variant === "ghost" ? "var(--color-foreground-contrast)" : "var(--color-foreground-default)"};` +
       `--text-color-active: ${variant === "ghost" ? "var(--color-foreground-emphasized)" : "var(--color-foreground-white)"};`,
   );
 </script>
@@ -231,6 +231,10 @@
     background-color: var(--button-color-1);
   }
 
+  .container:hover:not(.disabled) {
+    color: var(--text-color);
+  }
+
   .container.active:not(.disabled) {
     color: var(--text-color-active);
   }

rudolfs pushed revision 55 43ae7e8b55374b5bb2b196c6c52809a1752ff821 on base 5dacfd0edded380228b112e4fbac6d1b2915e49c +1084 -851 1 year ago

Apply rust suggestion

rudolfs pushed revision 56 12201215527349f8a2c28b747cf41fa385b459cd on base 5dacfd0edded380228b112e4fbac6d1b2915e49c +1086 -851 1 year ago

Fix button hover color in light mode