Move the inbox into a popover that’s accessible globally.
- refresh inbox counter and app icon badge every 3 seconds
- show a button to load new notifications in case new ones come in when the popover is open
- repo pinning and hiding
- simplify backend into one call
- load 100 notifications per repo and show a More button if there are more
- Inbox 0 message when there are no notifications
Move the inbox into a popover that’s accessible globally.
- refresh inbox counter and app icon badge every 3 seconds
- show a button to load new notifications in case new ones come in when the popover is open
- repo pinning and hiding
- simplify backend into one call
- load 100 notifications per repo and show a More button if there are more
- Inbox 0 message when there are no notifications
Hide counter if undefined
Rebase
Make the popover fixed height
Fix clear all modals
Rebase
Replace total count function
Rebase
Cleanup
Make confirm clear nicer
Small things
Update total notification counter on clear
Refactor
Rebase
Refactor 1
Refactor 2
Fixup
Fixup
Poll inbox counter and set app badge
Remove badge if we have 0 notifications
Squash
Fix specs
Patch looks good so far.
Do we want to collapse repos? I feel like having all repos listed in the global inbox and not being able to collapse them, makes the inbox a bit less usable for me.
Visual comments in the discussion thread, due to embeds
Rebase
Rebase
Narrow down sql queries
Refactor into one back-end call
Refactor
Implement repo pinning in inbox
Implement hiding too
Better sorting and visual alignments
Visual tweaks
Implement Show All notifications
Preserver pinning order and refresh notification list automatically
Is this revision of the patch final and reviewable or is there something missing?
Moving it back to draft, haven’t had time to do a revision on it yet.
Rebase
Squash
Fix router loading things twice
Move home router to its own module Load initial notification counter via router
Rebase
Rebase.
Squash
Make inbox variable height
Show a load more button when new notifications arrive
Fix counters
I think now it is.
Rebase
Rename and remove endpoints
Another rename
I’m going to do one final refactor of the notification backend before review.
Rebase
TBD:
- still some issue with total count vs per repo counts, seeing 7 total vs 6 inside, causes “See 1 new” button to appear and not go away, could be that a notification is counted towards total that isn’t part of a repo?
- backend call refactor
Rebase
Fix outline button color
Always show clear all buttons
Remove redundant comments
Try to fix rust-toolchain shenanigans
Add clippy
Fix check-rs
Revert
Remove clippy
Found a small design issue when in light theme the text of the inbox popover toggle is white and not readable. I recommend something like this
diff --git a/src/components/OutlineButton.svelte b/src/components/OutlineButton.svelte
index de9dfa4..6a8c191 100644
--- a/src/components/OutlineButton.svelte
+++ b/src/components/OutlineButton.svelte
@@ -29,7 +29,7 @@
`--button-color-3: var(--color-fill-${variant}-shade);` +
// The ghost colors are called --color-fill-counter and --color-fill-counter-emphasized.
`--button-color-4: var(--color-fill${variant === "ghost" ? "" : `-${variant}`}-counter);` +
- `--text-color: ${variant === "ghost" ? "var(--color-foreground-contrast)" : "var(--color-foreground-white)"};` +
+ `--text-color: ${variant === "ghost" ? "var(--color-foreground-contrast)" : "var(--color-foreground-default)"};` +
`--text-color-active: ${variant === "ghost" ? "var(--color-foreground-emphasized)" : "var(--color-foreground-white)"};`,
);
</script>
@@ -231,6 +231,10 @@
background-color: var(--button-color-1);
}
+ .container:hover:not(.disabled) {
+ color: var(--text-color);
+ }
+
.container.active:not(.disabled) {
color: var(--text-color-active);
}
Apply rust suggestion
Fix button hover color in light mode