Radish alpha
r
radicle-desktop
rad:z4D5UCArafTzTQpDZNQRuqswh3ury
Radicle desktop app
Radicle
Git
Patches › 482fadd9
Add informative note on review creation
Open rudolfs opened 1 year ago

We don’t have draft reviews and users get confused about how reviews work. This should help in the interim until we have proper draft reviews.

check check-e2e

👉 Workflow runs 👉 Branch on GitHub

Activity Changes +83 -64
1 file changed +83 -64 2c2a5abc → a5209a88
modified src/components/Reviews.svelte
@@ -109,70 +109,89 @@
        {/snippet}



        {#snippet popover()}
- 
          <Border variant="ghost" stylePadding="1rem">
- 
            <OutlineButton
- 
              variant="ghost"
- 
              disabled={hasOwnReview}
- 
              title={hasOwnReview
- 
                ? "You already published a review"
- 
                : undefined}
- 
              onclick={async () => {
- 
                const newReview = await createReview();
- 
                if (newReview) {
- 
                  await push({
- 
                    resource: "repo.patch",
- 
                    rid,
- 
                    patch: patchId,
- 
                    status,
- 
                    reviewId: newReview.id,
- 
                  });
- 
                }
- 
                closeFocused();
- 
              }}>
- 
              <span
- 
                class="global-flex"
- 
                style:color="var(--color-foreground-dim)">
- 
                <Icon name="comment" />
- 
                <span class="txt-small">Write Review</span>
- 
              </span>
- 
            </OutlineButton>
- 
            <OutlineButton
- 
              variant="ghost"
- 
              disabled={hasOwnReview}
- 
              title={hasOwnReview
- 
                ? "You already published a review"
- 
                : undefined}
- 
              onclick={async () => {
- 
                await createReview("reject");
- 
                await loadPatch();
- 
                closeFocused();
- 
              }}>
- 
              <span
- 
                class="global-flex"
- 
                style:color="var(--color-foreground-red)">
- 
                <Icon name="comment-cross" />
- 
                <span class="txt-small">Reject</span>
- 
              </span>
- 
            </OutlineButton>
- 
            <OutlineButton
- 
              variant="ghost"
- 
              disabled={hasOwnReview}
- 
              title={hasOwnReview
- 
                ? "You already published a review"
- 
                : undefined}
- 
              onclick={async () => {
- 
                await createReview("accept");
- 
                await loadPatch();
- 
                closeFocused();
- 
              }}>
- 
              <span
- 
                class="global-flex"
- 
                style:color="var(--color-foreground-success)">
- 
                <Icon name="comment-checkmark" />
- 
                <span class="txt-small">Accept</span>
- 
                <span></span>
- 
              </span>
- 
            </OutlineButton>
+ 
          <Border
+ 
            variant="ghost"
+ 
            stylePadding="1rem"
+ 
            styleDisplay="flex"
+ 
            styleFlexDirection="column">
+ 
            <div class="global-flex">
+ 
              <OutlineButton
+ 
                variant="ghost"
+ 
                disabled={hasOwnReview}
+ 
                title={hasOwnReview
+ 
                  ? "You already published a review"
+ 
                  : undefined}
+ 
                onclick={async () => {
+ 
                  const newReview = await createReview();
+ 
                  if (newReview) {
+ 
                    await push({
+ 
                      resource: "repo.patch",
+ 
                      rid,
+ 
                      patch: patchId,
+ 
                      status,
+ 
                      reviewId: newReview.id,
+ 
                    });
+ 
                  }
+ 
                  closeFocused();
+ 
                }}>
+ 
                <span
+ 
                  class="global-flex"
+ 
                  style:color="var(--color-foreground-dim)">
+ 
                  <Icon name="comment" />
+ 
                  <span class="txt-small">Write Review</span>
+ 
                </span>
+ 
              </OutlineButton>
+ 
              <OutlineButton
+ 
                variant="ghost"
+ 
                disabled={hasOwnReview}
+ 
                title={hasOwnReview
+ 
                  ? "You already published a review"
+ 
                  : undefined}
+ 
                onclick={async () => {
+ 
                  await createReview("reject");
+ 
                  await loadPatch();
+ 
                  closeFocused();
+ 
                }}>
+ 
                <span
+ 
                  class="global-flex"
+ 
                  style:color="var(--color-foreground-red)">
+ 
                  <Icon name="comment-cross" />
+ 
                  <span class="txt-small">Reject</span>
+ 
                </span>
+ 
              </OutlineButton>
+ 
              <OutlineButton
+ 
                variant="ghost"
+ 
                disabled={hasOwnReview}
+ 
                title={hasOwnReview
+ 
                  ? "You already published a review"
+ 
                  : undefined}
+ 
                onclick={async () => {
+ 
                  await createReview("accept");
+ 
                  await loadPatch();
+ 
                  closeFocused();
+ 
                }}>
+ 
                <span
+ 
                  class="global-flex"
+ 
                  style:color="var(--color-foreground-success)">
+ 
                  <Icon name="comment-checkmark" />
+ 
                  <span class="txt-small">Accept</span>
+ 
                  <span></span>
+ 
                </span>
+ 
              </OutlineButton>
+ 
            </div>
+
+ 
            <div
+ 
              class="txt-small txt-missing global-flex"
+ 
              style:margin-top="0.5rem"
+ 
              style:align-items="flex-start">
+ 
              <div style:padding-top="3px"><Icon name="info" /></div>
+ 
              <div>
+ 
                Clicking the buttons will create a blank review, add comments, a
+ 
                summary, and your verdict after. Depending on your sync settings
+ 
                your review might be published to the network right away. We are
+ 
                actively working on draft reviews, stay tuned.
+ 
              </div>
+ 
            </div>

          </Border>

        {/snippet}

      </Popover>