Radish alpha
r
radicle-desktop
rad:z4D5UCArafTzTQpDZNQRuqswh3ury
Radicle desktop app
Radicle
Git
Patches › 1fa868d4
Fix revision teaser background color
Open rudolfs opened 1 year ago

We improperly showed reviews without verdict as rejected.

check check-e2e

👉 Workflow runs 👉 Branch on GitHub

Activity Changes +64 -45
2 files changed +64 -45 c4bef0e9 → d6631ab8
added src/components/ReviewTeaser.svelte
@@ -0,0 +1,61 @@
+ 
<script lang="ts">
+ 
  import type { Review } from "@bindings/cob/patch/Review";
+
+ 
  import {
+ 
    absoluteTimestamp,
+ 
    authorForNodeId,
+ 
    formatTimestamp,
+ 
  } from "@app/lib/utils";
+
+ 
  import Icon from "./Icon.svelte";
+ 
  import Markdown from "./Markdown.svelte";
+ 
  import NodeId from "@app/components/NodeId.svelte";
+
+ 
  interface Props {
+ 
    rid: string;
+ 
    review: Review;
+ 
  }
+
+ 
  const { rid, review }: Props = $props();
+
+ 
  const backgroundColor = {
+ 
    review: "var(--color-background-float)",
+ 
    accept: "var(--color-fill-diff-green-light)",
+ 
    reject: "var(--color-fill-diff-red-light)",
+ 
  };
+ 
</script>
+
+ 
<style>
+ 
  .review {
+ 
    clip-path: var(--2px-corner-fill);
+ 
    padding: 0.5rem 0.75rem;
+ 
    font-size: var(--font-size-small);
+ 
    display: flex;
+ 
    flex-direction: column;
+ 
    gap: 0.5rem;
+ 
  }
+ 
</style>
+
+ 
<div
+ 
  class="review"
+ 
  style:background-color={backgroundColor[review.verdict ?? "review"]}>
+ 
  <div class="global-flex">
+ 
    <NodeId {...authorForNodeId(review.author)} />
+ 
    {review.verdict ? `${review.verdict}ed` : "reviewed"} revision
+ 
    <div title={absoluteTimestamp(review.timestamp)}>
+ 
      {formatTimestamp(review.timestamp)}
+ 
    </div>
+ 
    {#if review.comments.length > 0}
+ 
      <div class="global-flex" style:gap="0.25rem" style:margin-left="auto">
+ 
        <Icon name="comment" />{review.comments.length}
+ 
      </div>
+ 
    {/if}
+ 
  </div>
+ 
  <div>
+ 
    {#if review.summary?.trim()}
+ 
      <Markdown {rid} breaks content={review.summary} />
+ 
    {:else}
+ 
      <span class="txt-missing">No summary.</span>
+ 
    {/if}
+ 
  </div>
+ 
</div>
modified src/components/Revision.svelte
@@ -13,21 +13,14 @@
  import { announce } from "@app/components/AnnounceSwitch.svelte";

  import { invoke } from "@app/lib/invoke";

  import { nodeRunning } from "@app/lib/events";
- 
  import {
- 
    absoluteTimestamp,
- 
    authorForNodeId,
- 
    formatTimestamp,
- 
    publicKeyFromDid,
- 
    scrollIntoView,
- 
  } from "@app/lib/utils";
+ 
  import { publicKeyFromDid, scrollIntoView } from "@app/lib/utils";



  import Changeset from "@app/components/Changeset.svelte";

  import CommentComponent from "@app/components/Comment.svelte";

  import CommentToggleInput from "@app/components/CommentToggleInput.svelte";

  import Icon from "@app/components/Icon.svelte";
- 
  import NodeId from "@app/components/NodeId.svelte";
+ 
  import ReviewTeaser from "@app/components/ReviewTeaser.svelte";

  import ThreadComponent from "@app/components/Thread.svelte";
- 
  import Markdown from "./Markdown.svelte";



  interface Props {

    rid: string;
@@ -260,14 +253,6 @@
    margin-left: 1.25rem;

    background-color: var(--color-background-float);

  }
- 
  .review {
- 
    clip-path: var(--2px-corner-fill);
- 
    padding: 0.5rem 0.75rem;
- 
    font-size: var(--font-size-small);
- 
    display: flex;
- 
    flex-direction: column;
- 
    gap: 0.5rem;
- 
  }

</style>



<div class="txt-small patch-body">
@@ -350,34 +335,7 @@
    </div>

    <div class:hide={hideReviews}>

      {#each revision.reviews as review}
- 
        <div
- 
          class="review"
- 
          style:background-color={review.verdict === "accept"
- 
            ? "var(--color-fill-diff-green-light)"
- 
            : "var(--color-fill-diff-red-light)"}>
- 
          <div class="global-flex">
- 
            <NodeId {...authorForNodeId(review.author)} />
- 
            {review.verdict === "accept" ? "accepted" : "rejected"} revision
- 
            <div title={absoluteTimestamp(review.timestamp)}>
- 
              {formatTimestamp(review.timestamp)}
- 
            </div>
- 
            {#if review.comments.length > 0}
- 
              <div
- 
                class="global-flex"
- 
                style:gap="0.25rem"
- 
                style:margin-left="auto">
- 
                <Icon name="comment" />{review.comments.length}
- 
              </div>
- 
            {/if}
- 
          </div>
- 
          <div>
- 
            {#if review.summary?.trim()}
- 
              <Markdown {rid} breaks content={review.summary} />
- 
            {:else}
- 
              <span class="txt-missing">No summary.</span>
- 
            {/if}
- 
          </div>
- 
        </div>
+ 
        <ReviewTeaser {rid} {review} />

      {/each}

    </div>

  </div>