Radish alpha
r
rad:z4D5UCArafTzTQpDZNQRuqswh3ury
Radicle desktop app
Radicle
Git
Draft reviews before publishing
Open did:key:z6Mki9XN...FvWF opened 10 months ago

Reviews are locally persisted but only published to the network by an explicit user action.

  • Delete line comments on draft reviews
did:key:z6Mki9XN...FvWF opened with revision 1d6e795c on base 30710d51 +599 -310 10 months ago

Reviews are locally persisted but only published to the network by an explicit user action.

  • Delete line comments on draft reviews
did:key:z6Mki4CG...o5Zr commented on revision 1 10 months ago

Woodpecker pipeline #977 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/521
did:key:z6Mki4CG...o5Zr commented on revision 1 10 months ago

Woodpecker pipeline #977 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/521
did:key:z6Mki4CG...o5Zr commented on revision 1 10 months ago

Woodpecker pipeline #977 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/521
did:key:z6Mki4CG...o5Zr commented on revision 1 10 months ago

Woodpecker pipeline #977 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/521
did:key:z6Mki4CG...o5Zr commented on revision 1 10 months ago

Woodpecker pipeline #977 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/521
did:key:z6Mki4CG...o5Zr commented on revision 1 10 months ago

Woodpecker pipeline #977 completed with status: failure. ❌

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/521
rudolfs reviewed 10 months ago

Nice work! Tried it, does the job.

I’m missing these things for full happiness:

  • add regular top-level (not on a line of code) review comments
  • ability to delete line comments in draft review (this could also be a follow-up)
  • delete draft review altogether (this could also be a follow-up)
did:key:z6MkkfM3...sVz5 reviewed 10 months ago

Nice work!

Did try the patch, and works as intended, I have some stylistic suggestions for the code that I could provide once the patch is ready.

did:key:z6Mki9XN...FvWF pushed revision 2 b1f4c55a on base d35920b8 +562 -294 10 months ago
did:key:z6Mki9XN...FvWF pushed revision 3 da368648 on base d35920b8 +562 -294 10 months ago

Fix eslint errors

did:key:z6MkkfM3...sVz5 pushed revision 4 8ca7e6d7 on base d35920b8 +548 -293 10 months ago
  • Sort imports, separate type imports into own section
  • Make DraftReview extend from Review
  • Use shorthand property in props
did:key:z6MkkfM3...sVz5 pushed revision 5 9e0d81a4 on base d35920b8 +553 -293 10 months ago

Remove Make DraftReview extend from Review commit

rudolfs accepted 10 months ago

Nice work!