Radish alpha
r
Radicle desktop app
Radicle
Git (anonymous pull)
Log in to clone via SSH
Draft reviews before publishing
did:key:z6Mki9XN...FvWF wants to merge 2 commits into main · opened 10 months ago

Reviews are locally persisted but only published to the network by an explicit user action.

  • Delete line comments on draft reviews
did:key:z6Mki9XN...FvWF opened with revision 1d6e795c19fa5873b4429890a31e15e1a32b68f1 on base 30710d51818714feb132102ed267303045975f85 +599 -310 10 months ago
did:key:z6Mki9XN...FvWF marked as draft 10 months ago
did:key:z6Mki4CG...o5Zr commented on revision 1 10 months ago

Woodpecker pipeline #977 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/521
did:key:z6Mki4CG...o5Zr commented on revision 1 10 months ago

Woodpecker pipeline #977 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/521
did:key:z6Mki4CG...o5Zr commented on revision 1 10 months ago

Woodpecker pipeline #977 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/521
did:key:z6Mki4CG...o5Zr commented on revision 1 10 months ago

Woodpecker pipeline #977 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/521
did:key:z6Mki4CG...o5Zr commented on revision 1 10 months ago

Woodpecker pipeline #977 current status: created. ⏳

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/521
did:key:z6Mki4CG...o5Zr commented on revision 1 10 months ago

Woodpecker pipeline #977 completed with status: failure. ❌

  • Details: https://woodpecker.radworks.garden/repos/6/pipeline/521
rudolfs reviewed 10 months ago

Nice work! Tried it, does the job.

I'm missing these things for full happiness:

  • add regular top-level (not on a line of code) review comments
  • ability to delete line comments in draft review (this could also be a follow-up)
  • delete draft review altogether (this could also be a follow-up)
sebastinez reviewed 10 months ago

Nice work!

Did try the patch, and works as intended, I have some stylistic suggestions for the code that I could provide once the patch is ready.

did:key:z6Mki9XN...FvWF pushed revision 2 b1f4c55a6d1afff1f3e2eafea9051944ff2d3469 on base d35920b8cbc94b0a73507a515b19779e37efc233 +562 -294 10 months ago
did:key:z6Mki9XN...FvWF marked as ready 10 months ago
did:key:z6Mki9XN...FvWF pushed revision 3 da36864898bd660bdde8553bbfc75a8b8caf2e89 on base d35920b8cbc94b0a73507a515b19779e37efc233 +562 -294 10 months ago

Fix eslint errors

sebastinez pushed revision 4 8ca7e6d7d7cdc78c4b69e28f8597977a0bd179de on base d35920b8cbc94b0a73507a515b19779e37efc233 +548 -293 10 months ago
  • Sort imports, separate type imports into own section
  • Make DraftReview extend from Review
  • Use shorthand property in props
sebastinez pushed revision 5 9e0d81a4d3bfc1d3e3c939ce80f3a5de11fa022e on base d35920b8cbc94b0a73507a515b19779e37efc233 +553 -293 10 months ago

Remove Make DraftReview extend from Review commit

rudolfs accepted 10 months ago

Nice work!