Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
This patchset implements two new flags:
Draft did:key:z6MkwcUR...q1kL opened 8 months ago

rad issue list –sort=

and

rad issue list --rsort=<mode>

to sort the issue listing.

did:key:z6MkwcUR...q1kL opened with revision eadaed60 on base 01bed73a +141 -10 8 months ago

rad issue list –sort=

and

rad issue list --rsort=<mode>

to sort the issue listing.

fintohaps commented on revision 1 8 months ago

I like the addition of sorting! However, sorting by comment count seems dubious to me. If I was to think sort by comments, my first instinct would be to sort by latest comments, i.e. which issues were commented on most recently.

did:key:z6MkwcUR...q1kL pushed revision 2 b93839d9 on base 1d7478cd +141 -10 8 months ago

Rebased.

did:key:z6MkgFq6...nBGz reviewed · 3 comments 8 months ago

Nice, thanks for the patch! I have to major points (and left a few inline comments):

  1. I’d prefer to rename the flag to sort-by (and in the help, call the value field). I think this stays more with the concepts and wording around databases
  2. I’d also make it possible to sort by timestamp (--sort-by date), such that I can have the oldest ones on top with --rsort-by date

Also, could you please reword the commit message such that it uses a component prefix, here cli: ...?

NOTE: Please also check the comments on the initial revision :)

did:key:z6MkgFq6...nBGz commented on revision 1 8 months ago

I think we could keep the comment count, if we would allow “piping” args, e.g. to find old issues with little attention you could do --rsort-by date --sort-by comments? Please note, that every issue at the least 1 top-level root comment.

Otherwise, I’m also fine with removing the comment count.

lorenz commented on revision 2 8 months ago

I like --sort-by, but at the same time I would like to suggest to reconsider --rsort and think about alternatives like --reverse, as we are used from git log, or maybe a flag --sort-descending.

did:key:z6MkwcUR...q1kL pushed revision 3 7fea1d09 on base f00d1d67 +141 -10 7 months ago

Rebased.