Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
cob: Fix patch review editing
Merged did:key:z6MksFqX...wzpT opened 1 year ago

Due to the way review editing was implemented, we were losing comments on previous review edits.

Here, we add a new review.edit action that is specifically for editing, and make the existing review action fail silently (for backwards compatibility) in case it is used when there is already a review.

We also simplify the review data structure by only keeping track of one review per author per revision, instead of all edits. Later, if needed, it will be possible to keep track of all review edits.

did:key:z6MksFqX...wzpT opened with revision bb10ba6c on base 729a6e05 +156 -52 1 year ago

Due to the way review editing was implemented, we were losing comments on previous review edits.

Here, we add a new review.edit action that is specifically for editing, and make the existing review action fail silently (for backwards compatibility) in case it is used when there is already a review.

We also simplify the review data structure by only keeping track of one review per author per revision, instead of all edits. Later, if needed, it will be possible to keep track of all review edits.

did:key:z6MksFqX...wzpT pushed revision 2 49e879ab on base 729a6e05 +187 -52 1 year ago

Address @fintan’s feedback.

did:key:z6MksFqX...wzpT merged revision 49e879ab at 3acdb17b 1 year ago