Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
test: fix backwards-incompatibility with git 2.34
Merged yorgos-laptop opened 1 year ago

As discussed on https://radicle.zulipchat.com/#narrow/stream/438104-nix/topic/version.20of.20git/near/440313515, the tests failed with git 2.34 (in an ubuntu:22.04 container) with:

--- Expected
++++ actual:   stdout
   1      - branch 'master' set up to track 'origin/master'.
        1 + Branch 'master' set up to track remote branch 'master' from 'origin'.

Exit status: 0

As per @fintohaps’ suggestion, this gets the tests passing again on git 2.34.

yorgos-laptop opened with revision b86383a9 on base 3403a66d +1 -1 1 year ago

As discussed on https://radicle.zulipchat.com/#narrow/stream/438104-nix/topic/version.20of.20git/near/440313515, the tests failed with git 2.34 (in an ubuntu:22.04 container) with:

--- Expected
++++ actual:   stdout
   1      - branch 'master' set up to track 'origin/master'.
        1 + Branch 'master' set up to track remote branch 'master' from 'origin'.

Exit status: 0

As per @fintohaps’ suggestion, this gets the tests passing again on git 2.34.

fintohaps accepted 1 year ago

Excellent change, could not have done it better myself

lorenz commented on revision 1 1 year ago

Is it possible to do prefix matching with ...? Then this would allow:

...'master' set up to track...

Is it possible to do case-insensitive or regex-based matching? Then this would allow:

[Bb]ranch 'master' set up to track...
fintohaps commented on revision 1 1 year ago

Is it possible to do prefix matching with ...? Then this would allow:

...'master' set up to track...

Is it possible to do case-insensitive or regex-based matching? Then this would allow:

[Bb]ranch 'master' set up to track...

I thought about something like this, but I don’t really see the benefit since we don’t really mind what Git says here. All that matters is that the command succeeded.

lorenz accepted 1 year ago

Aye, forget about my nitpicking then.

did:key:z6MksFqX...wzpT pushed revision 2 e3f5f1de on base a6e33ec1 +1 -1 1 year ago

Rebase.

did:key:z6MksFqX...wzpT merged revision e3f5f1de at ce99f7e7 1 year ago