This patchset rewrites how modules are declared (in radicle-cli, because this is the only crate that uses the… unconventional method of declaring modules).
The first patch cleans the thing up, the second patch deprecates the alternative module names. This one I think can be/should be discussed a bit more. I don’t want to just remove the alternative names with this patchset because that might break downstream - whoever that is… if it is only within this repository, lets go and just remove it! If external parties might be involved, we might wait for another release cycle?
The “self” module is a bit of a special case (included this also in the commit
message), because self is a identifier in Rust, so it actually has to be
rad_self here.
Can we think of a better name for the whole module?
That is all, happy to see your review!
This patchset rewrites how modules are declared (in radicle-cli, because this is the only crate that uses the… unconventional method of declaring modules).
The first patch cleans the thing up, the second patch deprecates the alternative module names. This one I think can be/should be discussed a bit more. I don’t want to just remove the alternative names with this patchset because that might break downstream - whoever that is… if it is only within this repository, lets go and just remove it! If external parties might be involved, we might wait for another release cycle?
The “self” module is a bit of a special case (included this also in the commit
message), because self is a identifier in Rust, so it actually has to be
rad_self here.
Can we think of a better name for the whole module?
That is all, happy to see your review!
Rebased
Also remove the deprecated modules, because they are not used anywhere outside the radicle-cli crate anyways.
Super cool, thanks!
I don’t want to just remove the alternative names with this patchset because that might break downstream - whoever that is…
Yeah, I am confused about this as well. And pub… This should be a binary
crate without any dependencies, right?!
If it is only within this repository, lets go and just remove it!
I think this is the case.
If external parties might be involved, we might wait for another release cycle?
Not required IMO.
The “self” module is a bit of a special case (included this also in the commit message), because
selfis a identifier in Rust, […]
Yup.
so it actually has to be
rad_selfhere.
I do not think so. How about r#self?
Can we think of a better name for the whole module?
I would prefer it to be the same as the actual command.
Argh, I commented on the wrong revision. Please see my comment on the initial revision of the patch. It applies to this revision. Sorry for my confusion.
Rebased.
How about r#self?
I was not able to code this somehow. Feel free to provide a !fixup patch!
Squash commits in previous revision and edit commit message.
Rebase.