Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
feat(config): add config option node.externalAddressFiles
Archived did:key:z6Mkpszi...nsaA opened 8 months ago

with externalAddressFile you can configure the external address or parts of it through a file(s) instead of putting the host/port into the config file. Motivation: this makes it easier for users to: - hide their host from their config - reuse their config - configure their externalAddress via an external program Example:

    "externalAddressesFiles": [
      {
        "type": "split",
        "host": {
          "file": "/var/lib/tor/onion/radicle/host"
        },
        "port": {
          "string": "42069"
        }
      },
      {
        "type": "full",
        "file": "/run/secrets/ext_full_host"
      }
    ]

for more see: https://radicle.zulipchat.com/#narrow/channel/383670-patches/topic/read.20externalAddresses.20from.20external.20file.20instead.20of.20config/with/532591796

did:key:z6Mkpszi...nsaA opened with revision 94a13374 on base 54fd8c40 +100 -11 8 months ago

with externalAddressFile you can configure the external address or parts of it through a file(s) instead of putting the host/port into the config file. Motivation: this makes it easier for users to: - hide their host from their config - reuse their config - configure their externalAddress via an external program Example:

    "externalAddressesFiles": [
      {
        "type": "split",
        "host": {
          "file": "/var/lib/tor/onion/radicle/host"
        },
        "port": {
          "string": "42069"
        }
      },
      {
        "type": "full",
        "file": "/run/secrets/ext_full_host"
      }
    ]

for more see: https://radicle.zulipchat.com/#narrow/channel/383670-patches/topic/read.20externalAddresses.20from.20external.20file.20instead.20of.20config/with/532591796

lorenz commented on revision 1 8 months ago

Copying my Zulip response from 2025-08-13, https://radicle.zulipchat.com/#narrow/channel/383670-patches/topic/read.20externalAddresses.20from.20external.20file.20instead.20of.20config/near/534234742:

Hey! Thanks for your suggestion and submitting a patch. I am against merging it, because it adds complexity to parsing the configuration. The particular patch you filed also introduces new possibilities for the radicle-node process to panic. Instead, I suggest you implement a solution outside of radicle-node, e.g. in your systemd unit or similar.

Since there was no reaction, I will archive this patch. If you want to revise it and have it be re-opened, feel free to comment on Radicle or message on Zulip. Thanks!