Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
cli: Don't use 'signer' where not necessary
Merged levitte opened 1 year ago

In the ‘clone’ command, a ‘signer’ is instanciated just to get the public key. In the ‘job’ command, a ‘signer’ is instanciated early, even when the subcommand doesn’t use it.

That’s unnecessary, and infers the potential use of RAD_PASSPHRASE. In those cases, avoid instanciating a ‘signer’.

levitte opened with revision 897efc90 on base 3b5fac17 +2 -5 1 year ago

In the ‘clone’ command, a ‘signer’ is instanciated just to get the public key. In the ‘job’ command, a ‘signer’ is instanciated early, even when the subcommand doesn’t use it.

That’s unnecessary, and infers the potential use of RAD_PASSPHRASE. In those cases, avoid instanciating a ‘signer’.

levitte pushed revision 2 097a1057 on base 3b5fac17 +6 -6 1 year ago
levitte pushed revision 3 66e91d1d on base 3b5fac17 +6 -6 1 year ago
levitte pushed revision 4 1d40d026 on base 3b5fac17 +7 -7 1 year ago

Fix of clippy error

fintohaps accepted 1 year ago

LGTM, thanks!

levitte pushed revision 5 729c9d85 on base c847a16e +7 -7 1 year ago

This patch could use some love, all I can do is rebase it…

fintohaps pushed revision 6 af6ebdff on base 538648c5 +7 -7 1 year ago

Rebased

fintohaps merged revision af6ebdff at 9abedf44 1 year ago