rebased on master
I have a fixup for this PR, but I fail to publish it right now.
Some small fixups.
Ah, here we go.
rebased on master
Hey there, sorry for the late reply. We really appreciate your contribution, thanks a lot for providing this patch :) I’ve done some testing and have a few (major) suggestions:
We have a pager in place in radicle_cli, so you could replace table.print_with_pager()? with crate::pager::run(&table)?;, Element::print_with_pager() can be removed then.
The output breaks for me because of overflowing lines in some cases with crate::pager::run(), but it also does with your initial implementation. So maybe we could try to fix radicle_term::io::viewport() instead? For this, I’d prefer to not to shell-out to e.g. stty, but rather try to find a way to make this more reliable using the libraries we have at hand, namely crossterm and console.
Please don’t hesitate to reach out in the Patches channel on Zulip.
rebased
Hey flepied,
Sorry about the delay on replying.
Appreciate the patch and I think the idea of having a pager is definitely something we would like to accept.
However, there are a lot of unrelated changes, including an AGENT.md file, and that is something we cannot nor will not accept as a patch.
If you’re still willing to add this feature, we’d love to accept a change that only implements paging the lists and removing any other unrelated changes.
If any of those changes are helpful, please provide separate patches for them.