Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
cob: use underlying git_ext::Oid for serde
Archived fintohaps opened 1 year ago

The use of bytes for serializing and deserializing was incorrect. It means that the serializing and deserializing of ObjectId and the underyling git_ext::Oid, which tends to cause issues with consumers of the API.

Change the Serialize and Deserialize implementations to defer to the git_ext::Oid implementations.

Add qcheck tests to ensure that these two types are compatible.

fintohaps opened with revision 79b25aa8 on base ccc0297b +42 -3 1 year ago

The use of bytes for serializing and deserializing was incorrect. It means that the serializing and deserializing of ObjectId and the underyling git_ext::Oid, which tends to cause issues with consumers of the API.

Change the Serialize and Deserialize implementations to defer to the git_ext::Oid implementations.

Add qcheck tests to ensure that these two types are compatible.

fintohaps pushed revision 2 fa71b4eb on base ccc0297b +78 -4 1 year ago

Changes:

  • maintain compatibility with deserializing bytes