Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
Remove dependency `radicle-surf`
Draft fintohaps opened 3 months ago

The main use of radicle-surf in the radicle-cli crate is for producing diffs. One use of diffs is in the review builder logic, which is obsolete. The other use is in producing diffs for the rad id proposal changes.

If the review code is removed and git-diff-tree is used for rad id, then the dependency on radicle-surf can be removed.

While removing rad patch review [--patch | --delete] can be seen as a non-backwards compatible change, the code is obsolete – so this is deemed safe.

Using git-diff-tree in place of a heartwood defined diff format comes with the consquence of displaying temporary tree and path information, e.g.:

diff --git a/radicle.json b/radicle.json
index 600d27b..b30194b 100644
--- a/radicle.json
+++ b/radicle.json

Some massaging of this output could be made, but that needs to be decided if it is worth it.

fintohaps opened with revision 68333e7f on base af3f0762 +28 -3172 3 months ago

The main use of radicle-surf in the radicle-cli crate is for producing diffs. One use of diffs is in the review builder logic, which is obsolete. The other use is in producing diffs for the rad id proposal changes.

If the review code is removed and git-diff-tree is used for rad id, then the dependency on radicle-surf can be removed.

While removing rad patch review [--patch | --delete] can be seen as a non-backwards compatible change, the code is obsolete – so this is deemed safe.

Using git-diff-tree in place of a heartwood defined diff format comes with the consquence of displaying temporary tree and path information, e.g.:

diff --git a/radicle.json b/radicle.json
index 600d27b..b30194b 100644
--- a/radicle.json
+++ b/radicle.json

Some massaging of this output could be made, but that needs to be decided if it is worth it.

lorenz pushed revision 2 1bc488a0 on base 02318f19 +43 -3203 3 months ago
  • Split up into separate commits
  • Introduce function for removed commands
  • Start work to use git2 for diffing in rad id