The main use of radicle-surf in the radicle-cli crate is for producing diffs.
One use of diffs is in the review builder logic, which is obsolete.
The other use is in producing diffs for the rad id proposal changes.
If the review code is removed and git-diff-tree is used for rad id, then the dependency on radicle-surf can be removed.
While removing rad patch review [--patch | --delete] can be seen as
a non-backwards compatible change, the code is obsolete – so this is
deemed safe.
Using git-diff-tree in place of a heartwood defined diff format
comes with the consquence of displaying temporary tree and path
information, e.g.:
diff --git a/radicle.json b/radicle.json
index 600d27b..b30194b 100644
--- a/radicle.json
+++ b/radicle.json
Some massaging of this output could be made, but that needs to be decided if it is worth it.
The main use of radicle-surf in the radicle-cli crate is for producing diffs.
One use of diffs is in the review builder logic, which is obsolete.
The other use is in producing diffs for the rad id proposal changes.
If the review code is removed and git-diff-tree is used for rad id, then the dependency on radicle-surf can be removed.
While removing rad patch review [--patch | --delete] can be seen as
a non-backwards compatible change, the code is obsolete – so this is
deemed safe.
Using git-diff-tree in place of a heartwood defined diff format
comes with the consquence of displaying temporary tree and path
information, e.g.:
diff --git a/radicle.json b/radicle.json
index 600d27b..b30194b 100644
--- a/radicle.json
+++ b/radicle.json
Some massaging of this output could be made, but that needs to be decided if it is worth it.
- Split up into separate commits
- Introduce function for removed commands
- Start work to use
git2for diffing inrad id