Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
radicle: Add `tempfile` to dev-dependencies
Merged lorenz opened 6 months ago

In commit 2149770a4b93ac731a025838e44e4c45edb3c3ff the dependency tempfile was made optional, and added to be enabled by the feature flag test. However, the tests of this crate itself need the dependency unconditionally as they want to create temporary directories.

This was not noticed earlier, since the error does not surface when the whole workspace is tested (cargo test --workspace), but only when the crate itself is tested (cargo test --package=radicle), because when testing the workspace, dependents of radicle will enable the test feature flag.

lorenz opened with revision 406e0390 on base 10e7b94c +1 -0 6 months ago

In commit 2149770a4b93ac731a025838e44e4c45edb3c3ff the dependency tempfile was made optional, and added to be enabled by the feature flag test. However, the tests of this crate itself need the dependency unconditionally as they want to create temporary directories.

This was not noticed earlier, since the error does not surface when the whole workspace is tested (cargo test --workspace), but only when the crate itself is tested (cargo test --package=radicle), because when testing the workspace, dependents of radicle will enable the test feature flag.

fintohaps pushed revision 2 31f3da94 on base 3e98589a +1 -0 6 months ago

Rebase

fintohaps merged revision 31f3da94 at 292befdb 6 months ago