Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
cli/inspect: use Clap
Merged levitte opened 6 months ago
levitte opened with revision 3097a313 on base 38ca038a +182 -238 6 months ago
levitte commented on revision 1 6 months ago

I’ve hit a bit of a snag. It seems that rad ., which I found is an alias for rad inspect with no arguments, doesn’t do what is expect of it.

I tried debugging with lldb, and it looks like the parsing bit for “inspect” in main.rs doesn’t quite parse it? … or at the very least, it looks like inspect’s run function is not called.

levitte pushed revision 2 75e35bdf on base 38ca038a +198 -235 6 months ago

A bit better structuring, I hope

levitte commented on revision 2 6 months ago

This still doesn’t solve the snag with rad . that I commented on in the previous revision

lorenz pushed revision 3 1c31fc71 on base 38ca038a +209 -236 6 months ago

Fix rad .

levitte pushed revision 4 26a62e99 on base 38ca038a +207 -234 6 months ago

Incorporated Lorenz’ reviews, with attribution and commit comments

Thank you for the reviews, Lorenz!

levitte commented on revision 4 6 months ago

This tests cleanly on my laptop at least

levitte commented on revision 4 6 months ago

Oh, right, maybe I should take this out of draft ;-)

lorenz pushed revision 5 d5d723bc on base 38ca038a +136 -118 6 months ago

Review

levitte pushed revision 6 ae58f6ce on base 38ca038a +136 -118 6 months ago

Incorporated all of Lorenz’ latestreview commits

lorenz pushed revision 7 d4f85bd6 on base 5ed1b8e5 +136 -118 6 months ago

Rebase

lorenz merged revision d4f85bd6 at 990e22ac 6 months ago