Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
Fix the test failures related to remote default branch (HEAD)
Merged levitte opened 10 days ago

The following two tests assumed that HEAD would always be there in the ‘rad’ remote. It turns out, however, that this isn’t necessarily the case, for example on Debian releases (as consistently noticed in multiple CI runs).

This change fixes this issue by explicitly setting the remote head, where this matters:

  • crates/radicle-cli/examples/rad-patch-fetch-2.md
  • crates/radicle-cli/examples/rad-patch-via-push.md
levitte opened with revision 2985d3a8 on base 07c62449 +2 -0 10 days ago

The following two tests assumed that HEAD would always be there in the ‘rad’ remote. It turns out, however, that this isn’t necessarily the case, for example on Debian releases (as consistently noticed in multiple CI runs).

This change fixes this issue by explicitly setting the remote head, where this matters:

  • crates/radicle-cli/examples/rad-patch-fetch-2.md
  • crates/radicle-cli/examples/rad-patch-via-push.md
levitte pushed revision 2 52778141 on base 07c62449 +6 -2 9 days ago

Fix the test failures related to remote default branch (HEAD)

The following two tests assumed that HEAD would always be there in the ‘rad’ remote. It turns out, however, that this isn’t necessarily the case, depending on the git version that’s used.

Git versions older that v2.48.0 do not touch ‘refs/remotes//HEAD’.

Git v2.48.0 and newer will update ‘refs/remotes//HEAD’ unless the configuration ‘remote..followRemoteHEAD’. With these versions, setting that configuration to “never” emulates the behaviour of older versions.

Therefore, to ensure that test results are consistent across pre-v2.48.0 git and v2.48.0 or newer git, the fixture of test repositories now include setting ‘remote.rad.followRemoteHEAD=never’, and adjusting the outputs that are affected.

These files are affected:

  • crates/radicle/src/test/fixtures.rs
  • crates/radicle-cli/examples/rad-patch-fetch-2.md
  • crates/radicle-cli/examples/rad-patch-via-push.md
lorenz pushed revision 3 d2180d66 on base 07c62449 +11 -2 8 days ago

Rewording

lorenz pushed revision 4 de4a8b5e on base 354805ae +0 -0 8 days ago

Rebase

lorenz merged revision de4a8b5e at 354805ae 8 days ago