Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
node: duplicate fetching logic respects RefsAt
Merged fintohaps opened 2 years ago

Two concurrent fetches can occur from the same peer, while also being for a different set of references. This was seen in the test_outdated_sigrefs test. Alice would have an ongoing fetch from Eve, and concurrently, Eve will create a new issue – thus creating a new RefsAt message – and Alice would attempt to fetch this.

The previous logic would only check that Alice is fetching from Eve and ignore the new updates – meaning the test could fail. However, if the RefsAt are checked then the other fetch can be recognised as new, and queue it.

fintohaps opened with revision 21e2f286 on base a48081f2 +16 -6 2 years ago

Two concurrent fetches can occur from the same peer, while also being for a different set of references. This was seen in the test_outdated_sigrefs test. Alice would have an ongoing fetch from Eve, and concurrently, Eve will create a new issue – thus creating a new RefsAt message – and Alice would attempt to fetch this.

The previous logic would only check that Alice is fetching from Eve and ignore the new updates – meaning the test could fail. However, if the RefsAt are checked then the other fetch can be recognised as new, and queue it.

did:key:z6MksFqX...wzpT pushed revision 2 60cb9071 on base 13d5b4f6 +14 -6 2 years ago

Rebase.

did:key:z6MksFqX...wzpT merged revision 60cb9071 at bb4ed84b 2 years ago