Radish alpha
h
heartwood
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
Patches › 1da708ae
radicle: Split `WriteRepository::set_head` up
Draft lorenz opened 7 months ago

The method set_head did two things:

  1. Compute the canonical head and set the default branch to target.
  2. Set the symbolic reference HEAD to target the default branch.

Split these two concerns into:

  1. set_default_branch_to_canonical_head
  2. set_head_to_default_branch
Activity Changes +0 -0
lorenz opened with revision 1da708ae on base f00d1d67 +67 -36 7 months ago

The method set_head did two things:

  1. Compute the canonical head and set the default branch to target.
  2. Set the symbolic reference HEAD to target the default branch.

Split these two concerns into:

  1. set_default_branch_to_canonical_head
  2. set_head_to_default_branch
did:key:z6MkwcUR...q1kL reviewed · 1 comment 7 months ago

There are ’todo!()’s in the code still, not sure whether this is intended.

lorenz commented on revision 1 7 months ago

The one todo!() is added intentionally.

lorenz pushed revision 2 a50f237c on base 646d4360 +66 -36 7 months ago

Work in Matthias’ suggestion and rebase.

lorenz commented on revision 1 7 months ago

Moving this back to draft, as I included it in patch/63b4e1d9046a2af75401f74234d7fc18b447109d and am not sure it will be needed after all.

Sign in with GitHub to comment