Radish alpha
h
heartwood
Radicle Heartwood Protocol & Stack
Radicle
Git (anonymous pull)
Log in to clone via SSH
Patches ›
radicle: Accept `<transport>::rad://` URL convention
✗ 0/1 checks passed did:key:z6MkrnXJ...SFS3 wants to merge 1 commit into master · opened 1 month ago

Extend the local transport URL parser to accept the standard Git <transport>::<address> format (see gitremote-helpers docs [1]) for remote helper composition.

This allows radicle repositories to have other remote helpers operate on the git repo, before content is handed over to git-remote-rad, as per the spec.

Note: Url::from_str accepts the prefixed form but Display always outputs canonical rad:// — the transport prefix is not part of the Radicle URL identity, so the round-trip is lossy by design.

[1] - https://git-scm.com/docs/gitremote-helpers#_invocation

Signed-off-by: Yorgos Saslis yorgos.work@proton.me

✗ Some checks failed — 0 passed, 1 failed View logs ↗
Activity Commits 1 Changes +27 -1
1 file changed +27 -1 22b2871f → 6c4656b4
modified crates/radicle/src/storage/git/transport/local/url.rs
@@ -18,7 +18,7 @@ pub enum UrlError {
    #[error("invalid url format: expected `rad://<repo>[/<namespace>]`")]

    InvalidFormat,

    /// Unsupported URL scheme.
- 
    #[error("unsupported scheme: expected `rad://`")]
+ 
    #[error("unsupported scheme: expected `rad://` or `<transport>::rad://`")]

    UnsupportedScheme,

    /// Invalid repository identifier.

    #[error("repo: {0}")]
@@ -79,6 +79,11 @@ impl FromStr for Url {
    fn from_str(s: &str) -> Result<Self, Self::Err> {

        let rest = s

            .strip_prefix("rad://")
+ 
            .or_else(|| {
+ 
                s.rsplit_once("::rad://")
+ 
                    .filter(|(prefix, _)| !prefix.is_empty())
+ 
                    .map(|(_, rest)| rest)
+ 
            })

            .ok_or(UrlError::UnsupportedScheme)?;

        let components = rest.split('/').collect::<Vec<_>>();
@@ -123,6 +128,27 @@ mod test {
        assert_eq!(url.repo, repo);

        assert_eq!(url.namespace, Some(namespace));
+ 
        // <transport>::rad:// (gitremote-helpers(7) convention)
+ 
        let url = format!("age::rad://{}", repo.canonical());
+ 
        let url = Url::from_str(&url).unwrap();
+
+ 
        assert_eq!(url.repo, repo);
+ 
        assert_eq!(url.namespace, None);
+
+ 
        let url = format!("age::rad://{}/{namespace}", repo.canonical());
+ 
        let url = Url::from_str(&url).unwrap();
+
+ 
        assert_eq!(url.repo, repo);
+ 
        assert_eq!(url.namespace, Some(namespace));
+
+ 
        // Negative cases for <transport>::rad:// convention.
+ 
        assert!(format!("::rad://{}", repo.canonical()).parse::<Url>().is_err());
+ 
        assert!(
+ 
            format!("age::heartwood://{}", repo.canonical())
+ 
                .parse::<Url>()
+ 
                .is_err()
+ 
        );
+ 


        assert!(

            format!("heartwood://{}", repo.canonical())

                .parse::<Url>()