Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
radicle/git/canonical: Actually use qualified refs
Merged lorenz opened 6 months ago

Some tests actually do not use qualified patterns. The removed lines should not compile because the qualified_pattern! proc macro should validate the string literals at compile time, but it contains a bug and actually does not assert well-formedness of qualified refspec patterns. Rectify.

1 file changed +10 -9 ee041d8d 30908dcf
modified crates/radicle/src/git/canonical/rules.rs
@@ -894,7 +894,8 @@ mod tests {
    #[test]
    fn test_order() {
        assert!(
-
            pattern(qualified_pattern!("a/b/c/d/*")) < pattern(qualified_pattern!("*/x")),
+
            pattern(qualified_pattern!("refs/heads/a/b/c/d/*"))
+
                < pattern(qualified_pattern!("refs/heads/*/x")),
            "example 1"
        );
        assert!(
@@ -930,17 +931,17 @@ mod tests {

        let pattern09 = pattern(qualified_pattern!("refs/foos/*"));

-
        let pattern10 = pattern(qualified_pattern!("a"));
-
        let pattern11 = pattern(qualified_pattern!("b"));
+
        let pattern10 = pattern(qualified_pattern!("refs/heads/a"));
+
        let pattern11 = pattern(qualified_pattern!("refs/heads/b"));

-
        let pattern12 = pattern(qualified_pattern!("a/*"));
-
        let pattern13 = pattern(qualified_pattern!("b/*"));
+
        let pattern12 = pattern(qualified_pattern!("refs/heads/a/*"));
+
        let pattern13 = pattern(qualified_pattern!("refs/heads/b/*"));

-
        let pattern14 = pattern(qualified_pattern!("a/*/ab"));
-
        let pattern15 = pattern(qualified_pattern!("a/*/a"));
+
        let pattern14 = pattern(qualified_pattern!("refs/heads/a/*/ab"));
+
        let pattern15 = pattern(qualified_pattern!("refs/heads/a/*/a"));

-
        let pattern16 = pattern(qualified_pattern!("a/*/b"));
-
        let pattern17 = pattern(qualified_pattern!("a/*/a"));
+
        let pattern16 = pattern(qualified_pattern!("refs/heads/a/*/b"));
+
        let pattern17 = pattern(qualified_pattern!("refs/heads/a/*/a"));

        // Test priority for path specificity
        assert!(