Radish alpha
h
rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5
Radicle Heartwood Protocol & Stack
Radicle
Git
node: Generalize commands announce/seeds to take public key
Merged lorenz opened 7 months ago

The commands “announce references” and “seeds” only take a repository ID, and carry the implicit assumption that the namespace with the same public key as the Node ID of the receiving radicle-node process is relevant, but no other namespace.

In the spirit of separating user and node identity, relax this, so that these command also carry the public key for which the announcement should be made or sync status should be reported.

This feature is not exposed via CLI, but used to pass through the user identity of the active profile.

For sync status, this patch still is not fully satisfactory, because the node does not store sync updates for all namespaces, but only for its own. Storing sync updates for namespaces that were announced from the node could be implemented in the future.

lorenz opened with revision 05db4d72 on base f1c7c986 +74 -37 7 months ago

The commands “announce references” and “seeds” only take a repository ID, and carry the implicit assumption that the namespace with the same public key as the Node ID of the receiving radicle-node process is relevant, but no other namespace.

In the spirit of separating user and node identity, relax this, so that these command also carry the public key for which the announcement should be made or sync status should be reported.

This feature is not exposed via CLI, but used to pass through the user identity of the active profile.

For sync status, this patch still is not fully satisfactory, because the node does not store sync updates for all namespaces, but only for its own. Storing sync updates for namespaces that were announced from the node could be implemented in the future.

lorenz pushed revision 2 101ab959 on base f1c7c986 +86 -39 7 months ago

Minor improvements.

lorenz pushed revision 3 5271370a on base f1c7c986 +143 -76 7 months ago

Also cover rad sync status.

lorenz pushed revision 4 48e82a78 on base 4787b53b +143 -76 7 months ago

Rebase

lorenz pushed revision 5 d9bb839a on base ee49e287 +143 -76 7 months ago

Rebase

lorenz pushed revision 6 943033ce on base 5cd016b5 +155 -65 6 months ago

Take not one but any number of namespaces.

lorenz pushed revision 7 ccae4f49 on base 6d698bb7 +155 -65 6 months ago

Rebase

lorenz pushed revision 8 1e4b2cd3 on base 2e77d5ef +191 -67 6 months ago

Also generalize the “seeds” command.

fintohaps pushed revision 9 febf2d4a on base 2e77d5ef +190 -67 6 months ago

REVIEW: fix broken test

The test Handle extends the updates with the provided NodeIds being announced.

In this scenario, we need to pass the NodeId that we’re using in the test if we’re checking the update on the other side.

lorenz pushed revision 10 b08ca30f on base 3992d519 +198 -67 6 months ago

Fix implementation of Handle for testing.

fintohaps pushed revision 11 152d9d8d on base 2e77d5ef +193 -61 6 months ago

REVIEW: another sketch

lorenz pushed revision 12 b24b2e58 on base 3992d519 +210 -76 6 months ago

Rethink, fix bugs, move defaulting logic to the very outer control socket layer.

lorenz pushed revision 13 a8cb033d on base 3992d519 +539 -284 6 months ago

Refactor for Fintan’s solution.

lorenz pushed revision 14 0774bc78 on base 7b8da0e7 +550 -293 6 months ago

Also generalize updating sync status.

fintohaps pushed revision 15 d322d23d on base 7b8da0e7 +552 -292 6 months ago

REVIEW: avoid the bool

fintohaps merged revision 0774bc78 at 7effa7c6 6 months ago