The commands “announce references” and “seeds” only take a repository ID,
and carry the implicit assumption that the namespace with the same public
key as the Node ID of the receiving radicle-node process is relevant,
but no other namespace.
In the spirit of separating user and node identity, relax this, so that these command also carry the public key for which the announcement should be made or sync status should be reported.
This feature is not exposed via CLI, but used to pass through the user identity of the active profile.
For sync status, this patch still is not fully satisfactory, because the node does not store sync updates for all namespaces, but only for its own. Storing sync updates for namespaces that were announced from the node could be implemented in the future.
The commands “announce references” and “seeds” only take a repository ID,
and carry the implicit assumption that the namespace with the same public
key as the Node ID of the receiving radicle-node process is relevant,
but no other namespace.
In the spirit of separating user and node identity, relax this, so that these command also carry the public key for which the announcement should be made or sync status should be reported.
This feature is not exposed via CLI, but used to pass through the user identity of the active profile.
For sync status, this patch still is not fully satisfactory, because the node does not store sync updates for all namespaces, but only for its own. Storing sync updates for namespaces that were announced from the node could be implemented in the future.
Minor improvements.
Also cover rad sync status.
Rebase
Rebase
Take not one but any number of namespaces.
Rebase
Also generalize the “seeds” command.
REVIEW: fix broken test
The test Handle extends the updates with the provided NodeIds being
announced.
In this scenario, we need to pass the NodeId that we’re using in the test if
we’re checking the update on the other side.
Fix implementation of Handle for testing.
REVIEW: another sketch
Rethink, fix bugs, move defaulting logic to the very outer control socket layer.
Refactor for Fintan’s solution.
Also generalize updating sync status.
REVIEW: avoid the bool