/*-
* Copyright(c) 2024 Baptiste Daroussin <bapt@FreeBSD.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <atf-c.h>
#include <private/pkg.h>
ATF_TC_WITHOUT_HEAD(cleanup_shlibs_required);
ATF_TC_WITHOUT_HEAD(cleanup_shlibs_required_multiple_provided);
ATF_TC_WITHOUT_HEAD(cleanup_shlibs_required_consecutive_provided);
ATF_TC_WITHOUT_HEAD(cleanup_shlibs_required_provided_ignore);
ATF_TC_WITHOUT_HEAD(cleanup_shlibs_required_internal_provided_sorted);
ATF_TC_BODY(cleanup_shlibs_required, tc)
{
struct pkg *p;
charv_t internal_provided = vec_init();
ATF_REQUIRE_EQ(pkg_new(&p, PKG_FILE), EPKG_OK);
ATF_REQUIRE(p != NULL);
vec_push(&p->shlibs_required, xstrdup("lib1.so:32"));
vec_push(&p->shlibs_required, xstrdup("lib1.so"));
vec_push(&p->shlibs_required, xstrdup("libA.so"));
vec_push(&p->shlibs_required, xstrdup("libA.so:32"));
pkg_cleanup_shlibs_required(p, &internal_provided);
ATF_REQUIRE_EQ(vec_len(&p->shlibs_required), 4);
vec_push(&p->shlibs_provided, "lib1.so");
pkg_cleanup_shlibs_required(p, &internal_provided);
ATF_REQUIRE_EQ(vec_len(&p->shlibs_required), 3);
vec_push(&internal_provided, "lib1.so:32");
pkg_cleanup_shlibs_required(p, &internal_provided);
ATF_REQUIRE_EQ_MSG(vec_len(&p->shlibs_required), 2, "expecint 2 got %zu", vec_len(&p->shlibs_required));
}
ATF_TC_BODY(cleanup_shlibs_required_multiple_provided, tc)
{
struct pkg *p;
charv_t internal_provided = vec_init();
ATF_REQUIRE_EQ(pkg_new(&p, PKG_FILE), EPKG_OK);
ATF_REQUIRE(p != NULL);
vec_push(&p->shlibs_required, xstrdup("lib1.so.1"));
vec_push(&p->shlibs_required, xstrdup("libA.so.2"));
vec_push(&p->shlibs_required, xstrdup("libB.so.2"));
vec_push(&p->shlibs_required, xstrdup("libC.so.2"));
vec_push(&p->shlibs_provided, xstrdup("libA.so.2"));
vec_push(&p->shlibs_provided, xstrdup("libC.so.3"));
vec_push(&p->shlibs_provided, xstrdup("libZ.so.3"));
ATF_REQUIRE_EQ(vec_len(&p->shlibs_required), 4);
pkg_cleanup_shlibs_required(p, &internal_provided);
ATF_REQUIRE_EQ(vec_len(&p->shlibs_required), 3);
ATF_REQUIRE_STREQ(p->shlibs_required.d[0], "lib1.so.1");
ATF_REQUIRE_STREQ(p->shlibs_required.d[1], "libB.so.2");
ATF_REQUIRE_STREQ(p->shlibs_required.d[2], "libC.so.2");
}
ATF_TC_BODY(cleanup_shlibs_required_consecutive_provided, tc)
{
struct pkg *p;
charv_t internal_provided = vec_init();
ATF_REQUIRE_EQ(pkg_new(&p, PKG_FILE), EPKG_OK);
ATF_REQUIRE(p != NULL);
vec_push(&p->shlibs_required, xstrdup("lib1.so.1"));
vec_push(&p->shlibs_required, xstrdup("libA.so.2"));
vec_push(&p->shlibs_required, xstrdup("libB.so.2"));
vec_push(&p->shlibs_required, xstrdup("libC.so.2"));
vec_push(&p->shlibs_provided, xstrdup("libA.so.2"));
vec_push(&p->shlibs_provided, xstrdup("libB.so.2"));
vec_push(&p->shlibs_provided, xstrdup("libZ.so.3"));
ATF_REQUIRE_EQ(vec_len(&p->shlibs_required), 4);
pkg_cleanup_shlibs_required(p, &internal_provided);
ATF_REQUIRE_EQ(vec_len(&p->shlibs_required), 2);
ATF_REQUIRE_STREQ(p->shlibs_required.d[0], "lib1.so.1");
ATF_REQUIRE_STREQ(p->shlibs_required.d[2], "libC.so.2");
}
ATF_TC_BODY(cleanup_shlibs_required_provided_ignore, tc)
{
struct pkg *p;
charv_t internal_provided = vec_init();
ATF_REQUIRE_EQ(pkg_new(&p, PKG_FILE), EPKG_OK);
ATF_REQUIRE(p != NULL);
vec_push(&p->shlibs_required, xstrdup("lib1.so.1"));
vec_push(&p->shlibs_required, xstrdup("libprivate.so.1"));
vec_push(&p->shlibs_required, xstrdup("libother.so.2"));
/* libprivate.so.1 is in shlibs_provided_ignore (e.g. from manifest
* or because it was not in SHLIB_PROVIDE_PATHS) */
charv_insert_sorted(&p->shlibs_provided_ignore, xstrdup("libprivate.so.1"));
ATF_REQUIRE_EQ(vec_len(&p->shlibs_required), 3);
pkg_cleanup_shlibs_required(p, &internal_provided);
ATF_REQUIRE_EQ(vec_len(&p->shlibs_required), 2);
ATF_REQUIRE_STREQ(p->shlibs_required.d[0], "lib1.so.1");
ATF_REQUIRE_STREQ(p->shlibs_required.d[1], "libother.so.2");
}
/*
* Regression test: internal_provided must be sorted for charv_search
* (bsearch) to work. With multiple entries added in reverse order,
* bsearch would silently fail to find valid entries if the vector
* were unsorted.
*/
ATF_TC_BODY(cleanup_shlibs_required_internal_provided_sorted, tc)
{
struct pkg *p;
charv_t internal_provided = vec_init();
ATF_REQUIRE_EQ(pkg_new(&p, PKG_FILE), EPKG_OK);
ATF_REQUIRE(p != NULL);
charv_insert_sorted(&p->shlibs_required, xstrdup("libA.so.1:32"));
charv_insert_sorted(&p->shlibs_required, xstrdup("libM.so.2:32"));
charv_insert_sorted(&p->shlibs_required, xstrdup("libZ.so.3:32"));
charv_insert_sorted(&p->shlibs_required, xstrdup("libunrelated.so.1"));
ATF_REQUIRE_EQ(vec_len(&p->shlibs_required), 4);
/* Insert in reverse order to ensure sorting matters */
charv_insert_sorted(&internal_provided, xstrdup("libZ.so.3:32"));
charv_insert_sorted(&internal_provided, xstrdup("libM.so.2:32"));
charv_insert_sorted(&internal_provided, xstrdup("libA.so.1:32"));
pkg_cleanup_shlibs_required(p, &internal_provided);
ATF_REQUIRE_EQ_MSG(vec_len(&p->shlibs_required), 1,
"expecting 1 got %zu", vec_len(&p->shlibs_required));
ATF_REQUIRE_STREQ(p->shlibs_required.d[0], "libunrelated.so.1");
vec_free_and_free(&internal_provided, free);
}
ATF_TP_ADD_TCS(tp)
{
ATF_TP_ADD_TC(tp, cleanup_shlibs_required);
ATF_TP_ADD_TC(tp, cleanup_shlibs_required_multiple_provided);
ATF_TP_ADD_TC(tp, cleanup_shlibs_required_consecutive_provided);
ATF_TP_ADD_TC(tp, cleanup_shlibs_required_provided_ignore);
ATF_TP_ADD_TC(tp, cleanup_shlibs_required_internal_provided_sorted);
return (atf_no_error());
}