Radish alpha
r
rad:zwTxygwuz5LDGBq255RA2CbNGrz8
Radicle CI broker
Radicle
Git
fix(ci-broker.md): avoid race condition by waiting up to a limit
Merged liw opened 1 year ago

Previously we did “sleep 0.1” to wait for the mock node daemon (synthetic-events) to delete the control socket, when it ends. This is too short for some environments where the scenario gets run.

Fix this by waiting for the socket to be deleted for some reasonably large time limit, but checking for it being removed every second.

Signed-off-by: Lars Wirzenius liw@liw.fi

liw opened with revision ea15ef80 on base 40cb793a +33 -4 1 year ago

Previously we did “sleep 0.1” to wait for the mock node daemon (synthetic-events) to delete the control socket, when it ends. This is too short for some environments where the scenario gets run.

Fix this by waiting for the socket to be deleted for some reasonably large time limit, but checking for it being removed every second.

Signed-off-by: Lars Wirzenius liw@liw.fi

did:key:z6Mkg5ZT...qCHw commented on revision 1 1 year ago

No GiHub Actions Workflows found.

liw pushed revision 2 81c6bff2 on base dd043e01 +34 -4 1 year ago
did:key:z6Mkg5ZT...qCHw commented on revision 2 1 year ago

No GiHub Actions Workflows found.

liw pushed revision 3 6083d2f9 on base 58ceb336 +34 -4 1 year ago

Rebase on main.

did:key:z6Mkg5ZT...qCHw commented on revision 3 1 year ago

No GiHub Actions Workflows found.

liw pushed revision 4 ee656396 on base 58ceb336 +62 -14 1 year ago

fix: teach synthetic-events to connect to its daemon

This means we don’t need the non-portable nc.

Signed-off-by: Lars Wirzenius liw@liw.fi

did:key:z6Mkg5ZT...qCHw commented on revision 4 1 year ago

No GiHub Actions Workflows found.

liw pushed revision 5 fc0a5cc5 on base 58ceb336 +156 -69 1 year ago

fix(src/bin/synthetic-events.rs):

Fix client code to close its write end and read until end. This avoids crashing the daemon.

Also: Refactor into smaller functions, for comprehensibility. Log errors in the daemon to the log file. Write errors from other parts to stderr.

Signed-off-by: Lars Wirzenius liw@liw.fi

did:key:z6Mkg5ZT...qCHw commented on revision 5 1 year ago

No GiHub Actions Workflows found.

liw pushed revision 6 d9fafa20 on base 58ceb336 +163 -71 1 year ago

feat(src/bin/synthetic-events.rs): show daemon log when client fails

Signed-off-by: Lars Wirzenius liw@liw.fi

did:key:z6Mkg5ZT...qCHw commented on revision 6 1 year ago

No GiHub Actions Workflows found.

liw pushed revision 7 c048848f on base 58ceb336 +167 -70 1 year ago

debug: increase logging in daemon

Signed-off-by: Lars Wirzenius liw@liw.fi

did:key:z6Mkg5ZT...qCHw commented on revision 7 1 year ago

No GiHub Actions Workflows found.

liw pushed revision 8 8dfc435c on base 58ceb336 +168 -71 1 year ago

debug: try without timeout setting

Signed-off-by: Lars Wirzenius liw@liw.fi

did:key:z6Mkg5ZT...qCHw commented on revision 8 1 year ago

No GiHub Actions Workflows found.

liw pushed revision 9 17507ebf on base 58ceb336 +139 -71 1 year ago

Rebase the patch set with a more helpful commit message

And a less confusing history.

did:key:z6Mkg5ZT...qCHw commented on revision 9 1 year ago

No GiHub Actions Workflows found.

liw merged revision 17507ebf at e82503bf 1 year ago