Radish alpha
r
rad:zwTxygwuz5LDGBq255RA2CbNGrz8
Radicle CI broker
Radicle
Git
Fix filter predicates for `Not`
Merged fintohaps opened 1 year ago

Surfaced by the issue:

[rad issue show 46fc1376e12a964b5435e6594efb1cbc1731d56d](https://explorer.radicle.gr/nodes/seed.radicle.gr/rad:zwTxygwuz5LDGBq255RA2CbNGrz8/issues/46fc1376e12a964b5435e6594efb1cbc1731d56d)

When attempting to deserialize the Not variant an error would occur:

deserializing nested enum in EventFilter::Not from YAML is not supported yet

This limitation can be fixed by doing the following to the Not variant:

    Not(#[serde(with = "serde_yml::with::singleton_map")] Box<Self>)

I believe this allows serd_yml to perform some indirection to allow for the nested enum.

fintohaps opened with revision c8a3d725 on base ba9b4365 +146 -12 1 year ago

Surfaced by the issue:

[rad issue show 46fc1376e12a964b5435e6594efb1cbc1731d56d](https://explorer.radicle.gr/nodes/seed.radicle.gr/rad:zwTxygwuz5LDGBq255RA2CbNGrz8/issues/46fc1376e12a964b5435e6594efb1cbc1731d56d)

When attempting to deserialize the Not variant an error would occur:

deserializing nested enum in EventFilter::Not from YAML is not supported yet

This limitation can be fixed by doing the following to the Not variant:

    Not(#[serde(with = "serde_yml::with::singleton_map")] Box<Self>)

I believe this allows serd_yml to perform some indirection to allow for the nested enum.

liw pushed revision 2 691a3aa1 on base d0c6a8c8 +146 -12 1 year ago

rebase on main

liw pushed revision 3 e5563151 on base d0c6a8c8 +150 -15 1 year ago

Not takes list of operands

liw merged revision e5563151 at 9e84afec 1 year ago