Radish alpha
r
rad:zwTxygwuz5LDGBq255RA2CbNGrz8
Radicle CI broker
Radicle
Git
fix(src/pages.rs): use broker run id, always there
Merged liw opened 1 year ago

Co-worker reported that the unwrap of the optional adapter run id triggered a panic for them.

Each run has a unique broker run id, and an optional, non-unique adapter run id. Use the broker run id instead.

Actually, the whole PageBuilder type is now useless, but I’ll tackle that separately.

Signed-off-by: Lars Wirzenius liw@liw.fi

refactor: drop the PageBuilder type

After various previous changes, the PageBuilder::build now only calls StatusPage::new, so there’s no point in the type. Drop it.

Also replace StatusPage::new with StatusPage::default, for better style.

Signed-off-by: Lars Wirzenius liw@liw.fi

liw opened with revision 7db74ebf on base 84029fe1 +8 -69 1 year ago

Co-worker reported that the unwrap of the optional adapter run id triggered a panic for them.

Each run has a unique broker run id, and an optional, non-unique adapter run id. Use the broker run id instead.

Actually, the whole PageBuilder type is now useless, but I’ll tackle that separately.

Signed-off-by: Lars Wirzenius liw@liw.fi

refactor: drop the PageBuilder type

After various previous changes, the PageBuilder::build now only calls StatusPage::new, so there’s no point in the type. Drop it.

Also replace StatusPage::new with StatusPage::default, for better style.

Signed-off-by: Lars Wirzenius liw@liw.fi

did:key:z6Mkg5ZT...qCHw commented on revision 1 1 year ago

No GiHub Actions Workflows found.

liw merged revision 7db74ebf at e5873fd0 1 year ago