Radish alpha
r
rad:zwTxygwuz5LDGBq255RA2CbNGrz8
Radicle CI broker
Radicle
Git
Simplify how adapters are run
Closed { reason: Other } liw opened 10 months ago refactor

queueproc calls broker, which calls adatper, which actually runs the adapter. broker doesn’t seem to be otherwise used. It might make sense to merge it into queueproc or to merge broker and adatper. Or merge all three.

liw commented 8 months ago

Having re-reviewed the code, here’s a summary:

  • a thread in queueproc picks events, pushes them into a queue of picked events
  • N threads extract an event from queue of picked events, call src/broker.rs to run adapter
  • src/broker.rs constructs a trigger message and calls src/adapter.rs to actually run adapter

Each step is necessary and sufficiently complicated that I don’t want to mix it into other concerns. Code is good enough as is.

Closing this issue.