Radish alpha
r
rad:zwTxygwuz5LDGBq255RA2CbNGrz8
Radicle CI broker
Radicle
Git
Add time limit to adapters' execution
Closed { reason: Solved } did:key:z6MkkpTP...arsB opened 2 years ago

At current implementation Broker spawns a process for the adapter to serve each event. If the adapter for some reason blocks and never exists, the broker will endlessly wait for it. So, it’s reasonable that broker should limit the duration that an adapter can run in order to process an event. In case that the limit is exceeded, broker should kill the spawned process.
This time limit could be configurable per adapter. I would propose that 60 minutes would be a reasonable duration for this.

liw commented 2 years ago

This seems like a reasonable thing for the CI broker to support, yes.

liw commented 1 year ago

This was implemented in patch 3b16bdef54edcf6b622a438b5cb4bd4a12f2f4c6