Radish alpha
r
rad:zwTxygwuz5LDGBq255RA2CbNGrz8
Radicle CI broker
Radicle
Git
Allow adapter to declare platform information
Open levitte opened 9 months ago job-cob someday/maybe

Having played a little with jobcobtool, I realised that there’s a lack of build platform information that I believe many may want… thngs like operating system, operating system version, kernel version (where applicable), architecture (CPU), that sort of things.

I can see adapters declaring that with extra fields in the “triggered” message. Whether it’s a structured declaration (i.e. having subfields like “os”, “os-version”, “cpu”, …) or a free text “description”, or even both, I can’t tell what’s best.

This information could then be placed in the job COBs, and displayed with jobcobtool

liw commented 8 months ago

I would prefer to keep the job COBs small and notr start adding all sorts of potentially useful data to them. That’s not saying the information isn’t useful, I just don’t think it belongs in the job COB. If you’d like that to happen, please open an issue on the radicle-job crate and/or raise the topic in Zulip.

However, as far the Radicle CI broker and adapter are concened, some questions:

  • I can imagine use cases for this, but for clarify, could you explain why you’d use this? Or someone else?
  • Will this vary from run to run, or will it be static? If it’s static, I think it needs to be in the adapter specification in tyhe CI broker configuration.
  • If it varies, things get trickier. The broker/adapter protocol is hard to change, but doable if there’s a need. The CI broker could accept new optional fields in the response messages, without breaking things, it just needs to be done carefully.
  • Until then, the adapter can put anything it wants in the run log if creates one itself. If it doesn’t, it can do so.