Manual testing tells me it doens’t work.

Analysis:

• cib creates a TimeoutCommand and uses that to spawn a ChildProcess
• it reads all of the child’s stdout using a RealtimeLines
• it the waits for child to terminate using ChildProcess::wait

The timeout is only checkeed in ChildProcess::wait, not in RealtimeLines. This means that if the child doesn’t close its stdout, the waiting never starts happening. This means the max_run_time setting is effectively ignored.

I note that all working adapters, which are what cib spawns, only close their stdout after terminating.

Possible fixes:

• Change RealtimeLines to honor the dealine for max_run_time
• Restructure the timeoutcmd module API so that the calling thread doesn’t read stdout in a blocking way and is fed lines from the child’s stdout via a channel or something

Fixed-in: ac9261bb8e669cee9562e29da44a7e0308dcc490

Not actually fixed. Needs further debugging.

RealtimeLines::line does not react to timeout unless child process produces output.

Fixed-in: 27317200c10b027f6f32d9853976d974e52fd224

The adapter and all it’s child-processes are now reliably killed, again. There’s a problem with how the result is presented, which I’ll open as a separate issue.