Radish alpha
r
rad:z4V1sjrXqjvFdnCUbxPFqd5p4DtH5
Radicle web interface
Radicle
Git
Add a `noscript` tag for no javascript fallback
Merged did:key:z6MkkfM3...sVz5 opened 1 year ago

For users with no javascript extensions or just straight disabled javascript, we should have some nice looking fallback to at least explain they should enable javascript for radicle-explorer.

check check-visual check-unit-test check-http-client-unit-test check-radicle-httpd check-e2e check-build check-http

๐Ÿ‘‰ Preview ๐Ÿ‘‰ Workflow runs ๐Ÿ‘‰ Branch on GitHub

did:key:z6MkkfM3...sVz5 opened with revision fa5c8e7e on base 11b7a920 +23 -0 1 year ago

For users with no javascript extensions or just straight disabled javascript, we should have some nice looking fallback to at least explain they should enable javascript for radicle-explorer.

check check-visual check-unit-test check-http-client-unit-test check-radicle-httpd check-e2e check-build check-http

๐Ÿ‘‰ Preview ๐Ÿ‘‰ Workflow runs ๐Ÿ‘‰ Branch on GitHub

did:key:z6MkkfM3...sVz5 pushed revision 2 a457d5de on base 11b7a920 +44 -0 1 year ago

Improve design and rewrite text.

did:key:z6MkkfM3...sVz5 pushed revision 3 a7271b5d on base 11b7a920 +43 -0 1 year ago

Remove unused stylesheet link

rudolfs commented on revision 1 1 year ago

Whatโ€™s up with the e2e test failures?

 Error: Test failed because there was a console error in the app: TypeError: Cannot read properties of undefined (reading 'files')
rudolfs commented on revision 1 1 year ago

Iโ€™d also tweak the wording a little:

JavaScript is Required

This web app won't work without JavaScript.
Please enable JavaScript in your browser to continue.
rudolfs commented on revision 1 1 year ago

Ah and one more thing, when I enable JS the warning goes away and Iโ€™m left with a blank page, wonder if thereโ€™s a way to reload the app, so it actually shows something?

Looked around the web, seems like there isnโ€™t a good solution for this, letโ€™s punt on it.

did:key:z6MkkfM3...sVz5 commented on revision 1 1 year ago

Hmm seems like some tests flakiness will check why it happens

rudolfs pushed revision 4 f921bc14 on base fb851314 +43 -0 1 year ago

Rebase

rudolfs accepted 1 year ago
rudolfs merged revision f921bc14 at b6501604 1 year ago