Radish alpha
r
rad:z4V1sjrXqjvFdnCUbxPFqd5p4DtH5
Radicle web interface
Radicle
Git
Handle `json!` panick trying to serialize non utf8 lines
Merged did:key:z6MkkfM3...sVz5 opened 1 year ago

Instead of panicking when trying to handle non utf8 lines we should return null as line output.

This way we can on the frontend detect if a file has any lines the api wasn’t able to parse and fallback to show a file as a Binary File

check check-visual check-unit-test check-http-client-unit-test check-radicle-httpd check-e2e check-build check-http

👉 Preview 👉 Workflow runs 👉 Branch on GitHub

did:key:z6MkkfM3...sVz5 opened with revision ebfe70f6 on base 46d1c217 +11 -8 1 year ago

Instead of panicking when trying to handle non utf8 lines we should return null as line output.

This way we can on the frontend detect if a file has any lines the api wasn’t able to parse and fallback to show a file as a Binary File

check check-visual check-unit-test check-http-client-unit-test check-radicle-httpd check-e2e check-build check-http

👉 Preview 👉 Workflow runs 👉 Branch on GitHub

did:key:z6MkkfM3...sVz5 pushed revision 2 a4220d8e on base 46d1c217 +16 -20 1 year ago

Fix linter

did:key:z6MkkfM3...sVz5 pushed revision 3 342b6280 on base 46d1c217 +17 -21 1 year ago
did:key:z6MkkfM3...sVz5 commented on revision 1 1 year ago

The check-visual errors seem to be a browser render issue, not affected by this patch.

rudolfs accepted 1 year ago
rudolfs pushed revision 4 2fe1bbac on base 856caf0e +17 -21 1 year ago

Rebase

rudolfs merged revision 2fe1bbac at c132855d 1 year ago