Also adds a e2e test that allows us to avoid running into this race condition again.
π Preview
π Workflow runs
π Branch on GitHub
Also adds a e2e test that allows us to avoid running into this race condition again.
π Preview
π Workflow runs
π Branch on GitHub
We should only compare httpd and node state instead of the whole getNode response
Add e2e test to reproduce race condition, improve httpd storage event listener
Nice work! Could you add console.warning when parsing the HttpdState fails? If something is off there this will make it easier to debug. (In general, avoid failing silently on errors)
Regarding the tests: I donβt understand how they are supposed to test the changes. I ran them against the unpatched code and they pass
Nice work! Could you add console.warning when parsing the HttpdState fails? If something is off there this will make it easier to debug. (In general, avoid failing silently on errors)
Yeah no problem.
Regarding the tests: I donβt understand how they are supposed to test the changes. I ran them against the unpatched code and they pass
I had good results yesterday, by returning the node.config.connect array in a different order the storage event listener enters into a frenzy trying to run the checkState fn indefinitely.
I had mixed results yesterday, will take another look
Add console.warn when not able to parse localstorage storage event
Count requests to see if there is excessive requests that originate from flickering
Remove e2e test
Improve zod error catching
JSON.parse event old and new value before passing to zod
Add more zod to parse JSON safely
Reorder imports
Rebase
Revert back to something simple
Rebase.
Rebase.