Radish alpha
r
rad:z4V1sjrXqjvFdnCUbxPFqd5p4DtH5
Radicle web interface
Radicle
Git
Only compare httpd or node state for deciding to run `checkState`
Merged did:key:z6MkkfM3...sVz5 opened 2 years ago

Also adds a e2e test that allows us to avoid running into this race condition again.

check check-visual check-unit-test check-httpd-api-unit-test check-e2e check-build

πŸ‘‰ Preview
πŸ‘‰ Workflow runs
πŸ‘‰ Branch on GitHub

did:key:z6MkkfM3...sVz5 opened with revision bf8afb75 on base 69429cb0 +24 -4 2 years ago

Also adds a e2e test that allows us to avoid running into this race condition again.

check check-visual check-unit-test check-httpd-api-unit-test check-e2e check-build

πŸ‘‰ Preview
πŸ‘‰ Workflow runs
πŸ‘‰ Branch on GitHub

did:key:z6MkkfM3...sVz5 pushed revision 2 232e9f16 on base 69429cb0 +24 -4 2 years ago

We should only compare httpd and node state instead of the whole getNode response

did:key:z6MkkfM3...sVz5 pushed revision 3 3933cb4a on base 6340501b +156 -5 2 years ago

Add e2e test to reproduce race condition, improve httpd storage event listener

did:key:z6Mki9XN...FvWF commented on revision 3 2 years ago

Nice work! Could you add console.warning when parsing the HttpdState fails? If something is off there this will make it easier to debug. (In general, avoid failing silently on errors)

Regarding the tests: I don’t understand how they are supposed to test the changes. I ran them against the unpatched code and they pass

did:key:z6MkkfM3...sVz5 commented on revision 3 2 years ago

Nice work! Could you add console.warning when parsing the HttpdState fails? If something is off there this will make it easier to debug. (In general, avoid failing silently on errors)

Yeah no problem.

Regarding the tests: I don’t understand how they are supposed to test the changes. I ran them against the unpatched code and they pass

I had good results yesterday, by returning the node.config.connect array in a different order the storage event listener enters into a frenzy trying to run the checkState fn indefinitely. I had mixed results yesterday, will take another look

did:key:z6MkkfM3...sVz5 pushed revision 4 9697e125 on base 6340501b +159 -5 2 years ago

Add console.warn when not able to parse localstorage storage event

did:key:z6MkkfM3...sVz5 pushed revision 5 37baef3a on base 67e16ea7 +177 -5 2 years ago

Count requests to see if there is excessive requests that originate from flickering

did:key:z6MkkfM3...sVz5 pushed revision 6 0719670b on base 67e16ea7 +39 -5 2 years ago

Remove e2e test

did:key:z6MkkfM3...sVz5 pushed revision 7 1f71fa2c on base 67e16ea7 +48 -5 2 years ago

Improve zod error catching

did:key:z6MkkfM3...sVz5 pushed revision 8 8a7e6839 on base 67e16ea7 +52 -5 2 years ago

JSON.parse event old and new value before passing to zod

did:key:z6MkkfM3...sVz5 pushed revision 9 fba63bf5 on base 67e16ea7 +72 -5 2 years ago

Add more zod to parse JSON safely

did:key:z6MkkfM3...sVz5 pushed revision 10 6549b271 on base 67e16ea7 +72 -5 2 years ago

Reorder imports

did:key:z6MkkfM3...sVz5 pushed revision 11 e01f270e on base 45479ddf +72 -5 2 years ago

Rebase

did:key:z6MkkfM3...sVz5 pushed revision 12 abf9fd71 on base 45479ddf +35 -16 2 years ago

Revert back to something simple

rudolfs pushed revision 13 691aa98e on base b6e8bca1 +35 -16 2 years ago

Rebase.

rudolfs pushed revision 14 d0cd1355 on base 92895082 +35 -16 2 years ago

Rebase.

rudolfs accepted 2 years ago
rudolfs merged revision d0cd1355 at d7521a46 2 years ago