Radish alpha
r
rad:z4V1sjrXqjvFdnCUbxPFqd5p4DtH5
Radicle web interface
Radicle
Git
Reskin explorer with the new UI kit
Merged rudolfs opened 1 month ago
rudolfs opened with revision 90f7db26 on base 4eae95ab +1539 -591 1 month ago
rudolfs pushed revision 2 0e189dc1 on base 4eae95ab +2309 -844 1 month ago

Step: 2 first pass of typography

rudolfs pushed revision 3 08c2765a on base 4eae95ab +2362 -908 1 month ago

Fixups

rudolfs pushed revision 4 5797ad0b on base 4eae95ab +2448 -994 1 month ago

Step: 3 migrate border radii

rudolfs pushed revision 5 d91f95c3 on base 4eae95ab +2761 -1536 1 month ago

Step: 4 migrate icons

rudolfs pushed revision 6 421a8f9f on base 4eae95ab +2760 -1538 1 month ago

Step: 5 migrate elevations

rudolfs pushed revision 7 0d596a22 on base 4eae95ab +2774 -1544 1 month ago

Fix tests

rudolfs pushed revision 8 5dc78399 on base 4eae95ab +4192 -1843 1 month ago

Repo cards

rudolfs pushed revision 9 9d61ddff on base 4eae95ab +4357 -2118 1 month ago

Node view layout, avatars and repo card styling

rudolfs pushed revision 10 960bbb35 on base 4eae95ab +4742 -2588 1 month ago

More fixes

rudolfs pushed revision 11 3385896a on base 4eae95ab +4742 -2588 1 month ago

Squash

rudolfs pushed revision 12 078b2f1e on base 4eae95ab +4745 -2597 1 month ago

Replace font-preloads

julien pushed revision 13 49af5e91 on base 4eae95ab +4739 -2609 1 month ago

Fix invisible text in private badge variant

The .private badge had both color and background-color set to –color-feedback-warning-text, making the text invisible. Use –color-feedback-warning-bg for the background instead.

Replace undefined –border-radius-xs with –border-radius-sm

–border-radius-xs was used in 6 places but never defined, causing state indicator badges to lose their border radius. Use the existing –border-radius-sm token instead.

Define –txt-code-semibold and drop –txt-code-bold

Consolidate code font weights to two: regular (400) and semibold (600). The –txt-code-bold (700) token was only used in DiffStatBadge — switch it to semibold for consistency with the rest of the code typography.

Remove duplicate path in eye-slash icon

The same SVG path was rendered twice due to a copy-paste error.

Remove invalid flex-shrink from ActivityDiagram

The value “none” is not valid for flex-shrink and was being ignored. The min-width already prevents shrinking.

Fix alt text in UserAvatar component

Fix undefined CSS class in RepoAvatar placeholder

Use inline style instead of nonexistent bg-surface-subtle class.

Use semantic color tokens for text and border

Replace –color-surface-brand-primary with –color-text-brand for text color contexts and –color-border-brand for border and box-shadow contexts. Surface tokens are kept only for background-color properties where they are semantically correct.

Fix repo card layout to prevent description overflow

Replace absolute positioning of activity diagram with flex layout so content and activity sit side by side. Limit description to one line with ellipsis overflow.

Only show node banner when bannerUrl is available

Fix popover clipping inside sidebar overflow

Use position: fixed with computed viewport coordinates so popovers escape the sidebar overflow-y clipping. Remove position: sticky from sidebar as it created a containing block trapping fixed elements.

Revert “Fix popover clipping inside sidebar overflow”

This reverts commit 01f781aad7eea60de17d1124401afd844af6f34f.

Fix sidebar popover clipping

Remove position: sticky and overflow-y: auto from the left sidebar so that popovers inside it are not clipped by the overflow context.

Unify brand colors to blue

Remove green garden brand, make blue the single brand color. Remove desktop brand overrides as they are now redundant.

Move settings to sidebar, remove logo and header from node page

julien pushed revision 14 31894e04 on base 4eae95ab +4727 -2670 1 month ago

Fix invisible text in private badge variant

The .private badge had both color and background-color set to –color-feedback-warning-text, making the text invisible. Use –color-feedback-warning-bg for the background instead.

Replace undefined –border-radius-xs with –border-radius-sm

–border-radius-xs was used in 6 places but never defined, causing state indicator badges to lose their border radius. Use the existing –border-radius-sm token instead.

Define –txt-code-semibold and drop –txt-code-bold

Consolidate code font weights to two: regular (400) and semibold (600). The –txt-code-bold (700) token was only used in DiffStatBadge — switch it to semibold for consistency with the rest of the code typography.

Remove duplicate path in eye-slash icon

The same SVG path was rendered twice due to a copy-paste error.

Remove invalid flex-shrink from ActivityDiagram

The value “none” is not valid for flex-shrink and was being ignored. The min-width already prevents shrinking.

Fix alt text in UserAvatar component

Fix undefined CSS class in RepoAvatar placeholder

Use inline style instead of nonexistent bg-surface-subtle class.

Use semantic color tokens for text and border

Replace –color-surface-brand-primary with –color-text-brand for text color contexts and –color-border-brand for border and box-shadow contexts. Surface tokens are kept only for background-color properties where they are semantically correct.

Fix repo card layout to prevent description overflow

Replace absolute positioning of activity diagram with flex layout so content and activity sit side by side. Limit description to one line with ellipsis overflow.

Only show node banner when bannerUrl is available

Fix popover clipping inside sidebar overflow

Use position: fixed with computed viewport coordinates so popovers escape the sidebar overflow-y clipping. Remove position: sticky from sidebar as it created a containing block trapping fixed elements.

Revert “Fix popover clipping inside sidebar overflow”

This reverts commit 01f781aad7eea60de17d1124401afd844af6f34f.

Fix sidebar popover clipping

Remove position: sticky and overflow-y: auto from the left sidebar so that popovers inside it are not clipped by the overflow context.

Unify brand colors to blue

Remove green garden brand, make blue the single brand color. Remove desktop brand overrides as they are now redundant.

Move settings to sidebar, remove logo and header from node page

Revert “Move settings to sidebar, remove logo and header from node page”

This reverts commit 99344afa1a88e3f1d722cf2a7475aa9a2fb392dd.

Replace logo, hide on breadcrumb pages, unify settings to header

julien pushed revision 15 a084f0ee on base 4eae95ab +4741 -2670 1 month ago

Fix invisible text in private badge variant

The .private badge had both color and background-color set to –color-feedback-warning-text, making the text invisible. Use –color-feedback-warning-bg for the background instead.

Replace undefined –border-radius-xs with –border-radius-sm

–border-radius-xs was used in 6 places but never defined, causing state indicator badges to lose their border radius. Use the existing –border-radius-sm token instead.

Define –txt-code-semibold and drop –txt-code-bold

Consolidate code font weights to two: regular (400) and semibold (600). The –txt-code-bold (700) token was only used in DiffStatBadge — switch it to semibold for consistency with the rest of the code typography.

Remove duplicate path in eye-slash icon

The same SVG path was rendered twice due to a copy-paste error.

Remove invalid flex-shrink from ActivityDiagram

The value “none” is not valid for flex-shrink and was being ignored. The min-width already prevents shrinking.

Fix alt text in UserAvatar component

Fix undefined CSS class in RepoAvatar placeholder

Use inline style instead of nonexistent bg-surface-subtle class.

Use semantic color tokens for text and border

Replace –color-surface-brand-primary with –color-text-brand for text color contexts and –color-border-brand for border and box-shadow contexts. Surface tokens are kept only for background-color properties where they are semantically correct.

Fix repo card layout to prevent description overflow

Replace absolute positioning of activity diagram with flex layout so content and activity sit side by side. Limit description to one line with ellipsis overflow.

Only show node banner when bannerUrl is available

Fix popover clipping inside sidebar overflow

Use position: fixed with computed viewport coordinates so popovers escape the sidebar overflow-y clipping. Remove position: sticky from sidebar as it created a containing block trapping fixed elements.

Revert “Fix popover clipping inside sidebar overflow”

This reverts commit 01f781aad7eea60de17d1124401afd844af6f34f.

Fix sidebar popover clipping

Remove position: sticky and overflow-y: auto from the left sidebar so that popovers inside it are not clipped by the overflow context.

Unify brand colors to blue

Remove green garden brand, make blue the single brand color. Remove desktop brand overrides as they are now redundant.

Move settings to sidebar, remove logo and header from node page

Revert “Move settings to sidebar, remove logo and header from node page”

This reverts commit 99344afa1a88e3f1d722cf2a7475aa9a2fb392dd.

Replace logo, hide on breadcrumb pages, unify settings to header

Fix node address layout to wrap instead of single row

Improve repo card layout and hide activity on narrow cards

Adjust activity diagram size and responsive threshold

Fix profile sidebar name and key overflow

rudolfs pushed revision 16 a0e8f810 on base 4eae95ab +4741 -2670 1 month ago

Squash Julien’s commits

rudolfs pushed revision 17 6111d7d4 on base 4eae95ab +3473 -2670 1 month ago

Remove llm files

rudolfs pushed revision 18 1961a5b6 on base 4eae95ab +3508 -2696 1 month ago

Polish

rudolfs pushed revision 19 0129cfe7 on base 4eae95ab +3557 -2759 1 month ago

Styling tweaks

rudolfs pushed revision 20 06ad6a98 on base 4eae95ab +3611 -2783 1 month ago

Fix tests

rudolfs pushed revision 21 9e32118b on base 4eae95ab +3620 -2892 1 month ago

More tweaks

rudolfs pushed revision 22 c0193342 on base 4eae95ab +3625 -2912 1 month ago

More styling tweaks

julien commented on revision 1 1 month ago

@rudolfs, my machine picked this up. I’m not entirely sure about this but wanted to flag:

Svelte attribute interpolation uses {expr}, not ${expr}. The ${...} syntax only works inside JS backtick template literals, so in these places the expression renders literally instead of being evaluated:

  • src/views/repos/Issues.svelte:213
  • src/views/repos/Patches.svelte:223
  • src/views/repos/Cob/Revision.svelte:447
  • src/views/repos/History.svelte:164, 174

For example:

description="Please make sure you are able to connect to the seed <code>${baseUrlToString(api.baseUrl)}</code>"

should be:

description="Please make sure you are able to connect to the seed <code>{baseUrlToString(api.baseUrl)}</code>"
julien pushed revision 23 15829303 on base 4eae95ab +3623 -2920 1 month ago

Fix assorted bugs found during review

  • Remove debug background-color: pink from mobile footer
  • Fix missing closing paren in CSS var() in ContextRepo
  • Use merge timestamp instead of revision timestamp for merge timeline events in Revision
  • Fix activity.length >= 0 (always true) to > 0 in ActivityDiagram

Clean up code review findings

  • Fix color token typo: quarternary -> quaternary
  • Fix neutrals-alpha-light-700 duplicate value (should be 64% opacity)
  • Make Badge role=“button” and tabindex conditional on onClick
  • Remove unused global-flex class references
  • Remove invalid justify-items on flex container in Sidebar
  • Remove duplicate border-left in Patch metadata
  • Remove duplicate .txt-id rule from index.css (kept in typography.css)
julien pushed revision 24 6bf74853 on base 4eae95ab +3625 -2923 1 month ago

Fix assorted bugs found during review

  • Remove debug background-color: pink from mobile footer
  • Fix missing closing paren in CSS var() in ContextRepo
  • Use merge timestamp instead of revision timestamp for merge timeline events in Revision
  • Fix activity.length >= 0 (always true) to > 0 in ActivityDiagram

Clean up code review findings

  • Fix color token typo: quarternary -> quaternary
  • Fix neutrals-alpha-light-700 duplicate value (should be 64% opacity)
  • Make Badge role=“button” and tabindex conditional on onClick
  • Remove unused global-flex class references
  • Remove invalid justify-items on flex container in Sidebar
  • Remove duplicate border-left in Patch metadata
  • Remove duplicate .txt-id rule from index.css (kept in typography.css)

Fix breadcrumb avatar spacing and chevron alignment

  • Increase gap between avatar and hostname from 0.25rem to 0.5rem
  • Remove redundant margin-right on avatar class
  • Shift chevron-right icon 1px right for better visual centering

Fix inline code block sizing in titles

Inherit font-size from parent so code blocks scale with the title size instead of always using the small txt-code-regular size.

julien pushed revision 25 0464b4a6 on base 4eae95ab +3627 -2923 1 month ago

Fix assorted bugs found during review

  • Remove debug background-color: pink from mobile footer
  • Fix missing closing paren in CSS var() in ContextRepo
  • Use merge timestamp instead of revision timestamp for merge timeline events in Revision
  • Fix activity.length >= 0 (always true) to > 0 in ActivityDiagram

Clean up code review findings

  • Fix color token typo: quarternary -> quaternary
  • Fix neutrals-alpha-light-700 duplicate value (should be 64% opacity)
  • Make Badge role=“button” and tabindex conditional on onClick
  • Remove unused global-flex class references
  • Remove invalid justify-items on flex container in Sidebar
  • Remove duplicate border-left in Patch metadata
  • Remove duplicate .txt-id rule from index.css (kept in typography.css)

Fix breadcrumb avatar spacing and chevron alignment

  • Increase gap between avatar and hostname from 0.25rem to 0.5rem
  • Remove redundant margin-right on avatar class
  • Shift chevron-right icon 1px right for better visual centering

Fix inline code block sizing in titles

Inherit font-size from parent so code blocks scale with the title size instead of always using the small txt-code-regular size.

Fix settings popover hidden behind sidebar on mobile

The header popover had no stacking context, so on mobile the sidebar (z-index: 100) would overlap it. Give the header z-index: 200 so the popover renders on top.

rudolfs pushed revision 26 2c2b8b48 on base 4eae95ab +3625 -2921 1 month ago

Fix lints

rudolfs pushed revision 27 fac06782 on base 4eae95ab +3625 -2921 1 month ago

Squash

rudolfs pushed revision 28 e8639266 on base 4eae95ab +3626 -2922 1 month ago

Fix e2e spec

rudolfs pushed revision 29 d9356de9 on base 4eae95ab +3625 -2921 1 month ago

Fix markdown code block copy-to-clipboard functionality

rudolfs pushed revision 30 53c4a1e0 on base 4eae95ab +3640 -2921 1 month ago

Add test for markdown code block copy to clipboard

rudolfs pushed revision 31 047e06e1 on base 4eae95ab +3649 -2921 1 month ago

Tweak activity diagram

rudolfs pushed revision 32 a4a49023 on base 4eae95ab +3667 -2935 1 month ago

Inline txt-missing token, it doesn’t exist in the UI kit

rudolfs pushed revision 33 4010a812 on base 4eae95ab +3680 -2935 1 month ago

Fix lints

rudolfs pushed revision 34 3bd90029 on base 4eae95ab +3680 -2935 1 month ago

Squash

rudolfs commented on revision 1 1 month ago

Good catch. Fixed.

rudolfs pushed revision 35 bbeb3f80 on base 4eae95ab +3557 -2960 1 month ago

Code review

rudolfs pushed revision 36 571b7e62 on base 4eae95ab +3557 -2960 1 month ago

Squash

rudolfs pushed revision 37 5c849615 on base 4eae95ab +3557 -2960 1 month ago

Fix mime type

rudolfs pushed revision 38 74cd45d3 on base 4eae95ab +3560 -2974 1 month ago

Last fixes

rudolfs merged revision 74cd45d3 at fa85596b 1 month ago