Allow `radicle-external-link` components in commit descriptions — radicle-explorer

Some interactive elements (branch dropdowns, the user menu, the clone popover) need JavaScript. Reading repositories, issues, patches, and the docs works without it; submitting forms also works as long as you can reach them via direct links.

radicle-explorer

Radicle web interface

Allow `radicle-external-link` components in commit descriptions

sebastinez wants to merge 1 commit into master · opened 1 year ago

To allow some very basic hyperlinking in commit descriptions we can replace fully specified urls with a valid scheme into radicle-external-link components.

👉 Preview 👉 Workflow runs 👉 Branch on GitHub

Activity Commits 1 Changes +14 -1

sebastinez opened with revision 7659cda62d4bb78e85f23b7aebbc8ce4ab65dad9 on base c0b913f3925bfedb11e6afb4c10570ddd30db882 +13 -1 1 year ago

rudolfs reviewed · 1 comment 1 year ago

The email part of the author is now missing according to the visual spec. We probably still want to see that. Likely something to do with sanitizing the whole description. It might be that we now strip out also other things that would have been shown previously.

sebastinez pushed revision 2 fa68f4ab7f36b48aee02bad94b248b0716efff8d on base c0b913f3925bfedb11e6afb4c10570ddd30db882 +14 -1 1 year ago

Escape html characters before rendering commit description with lodash.escape

rudolfs accepted 1 year ago