Tweak design.
Nice work! I like the stripped parts and even more the new parts! Gives the node page a lot more sense and more information to clarify important concepts. :clap:
This seems redundant, since we don’t show it on a local node, but on a remote node, we won’t ever show projects that aren’t pinned. https://app.radicle.xyz/nodes/seed.radicle.garden/rad:z4V1sjrXqjvFdnCUbxPFqd5p4DtH5/patches/54630923408f4a838f8f194114dec028a061faea?tab=changes#src/views/nodes/View.svelte:H4L23H4L24
I think we can safely remove anything error related here, since we check for errors in the router
diff --git a/src/views/nodes/View.svelte b/src/views/nodes/View.svelte
index 29399986..68951f25 100644
--- a/src/views/nodes/View.svelte
+++ b/src/views/nodes/View.svelte
@@ -10,7 +10,6 @@
import AppLayout from "@app/App/AppLayout.svelte";
import CopyableId from "@app/components/CopyableId.svelte";
- import ErrorMessage from "@app/components/ErrorMessage.svelte";
import IconSmall from "@app/components/IconSmall.svelte";
import ProjectCard from "@app/components/ProjectCard.svelte";
import HoverPopover from "@app/components/HoverPopover.svelte";
@@ -23,8 +22,6 @@
export let policy: Policy | undefined = undefined;
export let scope: Scope | undefined = undefined;
- let error: any;
-
$: hostname = isLocal(baseUrl.hostname) ? "Local Node" : baseUrl.hostname;
$: session =
$httpdStore.state === "authenticated" && isLocal(api.baseUrl.hostname)
@@ -216,13 +215,6 @@
{baseUrl} />
{/each}
</div>
-
- {#if error}
- <ErrorMessage
- title="Not able to load more projects from this node"
- description="You either loaded all remaining projects, or there was a network issue with this seed"
- {error} />
- {/if}
</div>
</div>
</AppLayout>
A small nit, but I prefer to use else if if we check the same variable (even an else would suffice, but I guess that since more values can be added in the future it’s more future proof)
diff --git a/src/views/nodes/View.svelte b/src/views/nodes/View.svelte
index 29399986..68951f25 100644
--- a/src/views/nodes/View.svelte
+++ b/src/views/nodes/View.svelte
@@ -183,15 +180,17 @@
<div slot="popover" class="popover">
{#if policy === "allow"}
- All discovered repositories will get seeded,{/if}
- {#if policy === "block"}
- Only repositories marked as such will get seeded,{/if}
+ All discovered repositories will get seeded,
+ {:else if policy === "block"}
+ Only repositories marked as such will get seeded,
+ {/if}
{#if scope === "all"}
and all changes in those repos, made by any peer, will be
- synced.{/if}
- {#if scope === "followed"}
+ synced.
+ {:else if scope === "followed"}
and only changes made by explicitly followed peers will be
- synced.{/if}
+ synced.
+ {/if}
</div>
</HoverPopover>
</span>
Apply Sebastian’s suggestions.