Radish alpha
r
rad:z4V1sjrXqjvFdnCUbxPFqd5p4DtH5
Radicle web interface
Radicle
Git
Remove sinon in favor of existing APIs of playwright and vitest
Merged did:key:z6MkkfM3...sVz5 opened 1 year ago

We where using sinon in the playwright tests to simulate a different time, which since playwright@1.45.0 can be done with the Clock API calling page.clock.setFixedTime.

And to test the mutex executor we can use the vitest utils spy function vi.fn() instead of sinon.spy()

check check-visual check-unit-test check-http-client-unit-test check-radicle-httpd check-e2e check-build check-http

👉 Preview 👉 Workflow runs 👉 Branch on GitHub

did:key:z6MkkfM3...sVz5 opened with revision 40854ae8 on base 7c9f1a01 +19 -269 1 year ago

We where using sinon in the playwright tests to simulate a different time, which since playwright@1.45.0 can be done with the Clock API calling page.clock.setFixedTime.

And to test the mutex executor we can use the vitest utils spy function vi.fn() instead of sinon.spy()

check check-visual check-unit-test check-http-client-unit-test check-radicle-httpd check-e2e check-build check-http

👉 Preview 👉 Workflow runs 👉 Branch on GitHub

rudolfs accepted 1 year ago
rudolfs merged revision 40854ae8 at a34056b2 1 year ago