f09e3f6 Remove redundant `selectedCommit` route property — radicle-explorer

Radicle web interface

Remove redundant `selectedCommit` route property

Thomas Scholtes committed 2 years ago

commit f09e3f6edfc6bf0feb9109667d7e9a98eb847755
parent 9294e23ea49f691683df45120608df0b4934a62d

3 files changed +17 -16

modified src/views/projects/Browser.svelte

@@ -15,7 +15,6 @@

   export let baseUrl: BaseUrl;
   export let branches: Record<string, string> | undefined;
   export let commit: string;
   export let commitCount: number;
   export let contributorCount: number;
   export let path: string;

@@ -34,16 +33,18 @@

   const api = new HttpdClient(baseUrl);
   const fetchTree = async (path: string) => {
     return api.project.getTree(project.id, commit, path).catch(() => {
       blobResult = {
         ok: false,
         error: {
           message: "Not able to expand directory",
           path,
         },
       };
       return undefined;
     });
     return api.project
       .getTree(project.id, tree.lastCommit.id, path)
       .catch(() => {
         blobResult = {
           ok: false,
           error: {
             message: "Not able to expand directory",
             path,
           },
         };
         return undefined;
       });
   };
 </script>

@@ -182,7 +183,11 @@

             {path}
             blob={blobResult.blob}
             highlighted={blobResult.highlighted}
             rawPath={utils.getRawBasePath(project.id, baseUrl, commit)} />
             rawPath={utils.getRawBasePath(
               project.id,
               baseUrl,
               tree.lastCommit.id,
             )} />
         {:else}
           <Placeholder emoji="🍂">
             <span slot="title">

modified src/views/projects/View.svelte

@@ -61,7 +61,6 @@

     <Browser
       blobResult={view.blobResult}
       branches={view.params.loadedBranches}
       commit={view.params.selectedCommit}
       commitCount={view.params.loadedTree.stats.commits}
       contributorCount={view.params.loadedTree.stats.contributors}
       path={view.path}

modified src/views/projects/router.ts

@@ -75,7 +75,6 @@ interface LoadedSourceBrowsingParams {

   loadedBranches: Record<string, string> | undefined;
   loadedPeers: Remote[];
   loadedTree: Tree;
   selectedCommit: string;
 }
 export type BlobResult =

@@ -202,7 +201,6 @@ export async function loadProjectRoute(

         loadedBranches: branches,
         loadedPeers: peers,
         loadedTree: tree,
         selectedCommit: commit,
       };
       if (params.view.resource === "tree") {
         let blobResult: BlobResult;

@@ -295,7 +293,6 @@ export async function loadProjectRoute(

         loadedBranches: undefined,
         loadedPeers: peers,
         loadedTree: tree,
         selectedCommit: params.view.commitId,
       };
       const loadedCommit = await api.project.getCommitBySha(
         params.id,