d50f0ca Don't push empty project description to page title — radicle-explorer

Radicle web interface

Don't push empty project description to page title

Sebastian Martinez committed 2 years ago

commit d50f0ca43410040d87fee8334df263373e877a94
parent 27dcde41b0d33363949b2a75d4e4f7a0fb24f8ca

2 files changed +28 -1

modified src/views/projects/router.ts

@@ -943,7 +943,9 @@ export function projectTitle(loadedRoute: ProjectLoadedRoute) {

   if (loadedRoute.resource === "project.source") {
     title.push(loadedRoute.params.project.name);
     title.push(loadedRoute.params.project.description);
     if (loadedRoute.params.project.description.length > 0) {
       title.push(loadedRoute.params.project.description);
     }
   } else if (loadedRoute.resource === "project.commit") {
     title.push(loadedRoute.params.commit.commit.summary);
     title.push("commit");

modified tests/e2e/historyRouter.spec.ts

@@ -6,6 +6,7 @@ import {

   sourceBrowsingUrl,
   test,
 } from "@tests/support/fixtures.js";
 import { createProject } from "@tests/support/project";
 import {
   expectBackAndForwardNavigationWorks,
   expectUrlPersistsReload,

@@ -112,6 +113,30 @@ test.describe("project page navigation", () => {

     await expectUrlPersistsReload(page);
   });
   test("page title", async ({ page }) => {
     await page.goto(sourceBrowsingUrl, {
       waitUntil: "networkidle",
     });
     const title = await page.title();
     expect(title).toBe(
       "source-browsing · Git repository for source browsing tests",
     );
   });
   test("page title on project with empty description", async ({
     page,
     authenticatedPeer,
   }) => {
     const { rid } = await createProject(authenticatedPeer, {
       name: "ProjectWithNoDescription",
     });
     await page.goto(authenticatedPeer.ridUrl(rid), {
       waitUntil: "networkidle",
     });
     const title = await page.title();
     expect(title).toBe("ProjectWithNoDescription");
   });
   test("navigate project paths with an explicitly selected peer", async ({
     page,
   }) => {